You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@struts.apache.org by Andrew Paul <ow...@muha.net> on 2014/05/28 13:27:48 UTC
Struts Dojo Plugin is broken (2.3.16.3)
Hi!
If anyone else have issues with latest Struts Dojo, here's something for
you;
The error in question can be seen when the javascript error console
yells: "TypeError: "$Rev$".match(...) is null"
This happens because the current available Struts built from Git and not
Subversion.
When checking out from Subversion, it appends the revision number to all
instances of "$Rev$" in the files.
Git does not do keyword substitution.
This is the offending line;
https://github.com/apache/struts/blob/develop/plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts_dojo.js#L36
It looks like this when checked out from Subversion;
dojo.version={major:0,minor:4,patch:3,flag:"",revision:Number("$Rev:
670371 $".match(/[0-9]+/)[0]),toString:function(){
Now unfortunately it looks like this in the latest jar;
dojo.version={major:0,minor:4,patch:3,flag:"",revision:Number("$Rev$".match(/[0-9]+/)[0]),toString:function(){
So the .match() fails and kills Dojo.
Regards
AP.
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Struts Dojo Plugin is broken (2.3.16.3)
Posted by Lukasz Lenart <lu...@apache.org>.
2.3.18 in month or faster, 2.5 it's a longer story ;-)
2014-05-28 13:49 GMT+02:00 Andreas <an...@muha.net>:
> Ach, I was too lazy to check the bugrepo and only peeked if the trunk
> was changed.
>
> Anyway that is awesome news!
> Any hint on when we can expect 2.3.18 and 2.5?
>
> Regards
> AP.
>
> On 2014-05-28 18:37, Lukasz Lenart wrote:
>> https://issues.apache.org/jira/browse/WW-4349 :-)
>>
>> 2014-05-28 13:27 GMT+02:00 Andrew Paul <ow...@muha.net>:
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Struts Dojo Plugin is broken (2.3.16.3)
Posted by Andreas <an...@muha.net>.
Ach, I was too lazy to check the bugrepo and only peeked if the trunk
was changed.
Anyway that is awesome news!
Any hint on when we can expect 2.3.18 and 2.5?
Regards
AP.
On 2014-05-28 18:37, Lukasz Lenart wrote:
> https://issues.apache.org/jira/browse/WW-4349 :-)
>
> 2014-05-28 13:27 GMT+02:00 Andrew Paul <ow...@muha.net>:
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org
Re: Struts Dojo Plugin is broken (2.3.16.3)
Posted by Lukasz Lenart <lu...@apache.org>.
https://issues.apache.org/jira/browse/WW-4349 :-)
2014-05-28 13:27 GMT+02:00 Andrew Paul <ow...@muha.net>:
> Hi!
> If anyone else have issues with latest Struts Dojo, here's something for
> you;
>
>
> The error in question can be seen when the javascript error console
> yells: "TypeError: "$Rev$".match(...) is null"
>
> This happens because the current available Struts built from Git and not
> Subversion.
> When checking out from Subversion, it appends the revision number to all
> instances of "$Rev$" in the files.
> Git does not do keyword substitution.
>
> This is the offending line;
>
> https://github.com/apache/struts/blob/develop/plugins/dojo/src/main/resources/org/apache/struts2/static/dojo/struts_dojo.js#L36
>
> It looks like this when checked out from Subversion;
>
> dojo.version={major:0,minor:4,patch:3,flag:"",revision:Number("$Rev:
> 670371 $".match(/[0-9]+/)[0]),toString:function(){
>
> Now unfortunately it looks like this in the latest jar;
>
>
> dojo.version={major:0,minor:4,patch:3,flag:"",revision:Number("$Rev$".match(/[0-9]+/)[0]),toString:function(){
>
> So the .match() fails and kills Dojo.
>
>
> Regards
> AP.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
> For additional commands, e-mail: user-help@struts.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@struts.apache.org
For additional commands, e-mail: user-help@struts.apache.org