You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/11/21 12:07:15 UTC

[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1235: IGNITE-17886 Table commands conversion to network messages

ibessonov commented on code in PR #1235:
URL: https://github.com/apache/ignite-3/pull/1235#discussion_r1001731046


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableMessageGroup.java:
##########
@@ -125,4 +125,23 @@ public interface TableMessageGroup {
      * Message type for {@link SnapshotTxDataResponse}.
      */
     short SNAPSHOT_TX_DATA_RESPONSE = 16;
+
+    /**
+     *
+     */
+    public interface Commands {

Review Comment:
   Please add a little comment to the class and for each constant. `Message type for {@link Foo}.` is enough, like for other messages



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org