[jira] [Commented] (FLEX-33893) CSSStyleDeclaration is inefficient during style matching

["Justin Mclean (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLEX-33893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858132#comment-13858132 ] 

Justin Mclean commented on FLEX-33893:
--------------------------------------

Checked into develop branch. Wait for full test run before resolving issue.

> CSSStyleDeclaration is inefficient during style matching
> --------------------------------------------------------
>
>                 Key: FLEX-33893
>                 URL: https://issues.apache.org/jira/browse/FLEX-33893
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: Mobile: Performance, Performance: Framework, Styles
>    Affects Versions: Apache Flex 4.11.0
>         Environment: desktop mobile
>            Reporter: Benoit Wiart
>            Assignee: Justin Mclean
>              Labels: memory, patch, performance
>         Attachments: 0001-cssstyledeclaration-optimization.patch, cssstyledeclaration-example-1-mobile.png, cssstyledeclaration-example-2-mobile.png, protochain-before-after.png
>
>
> When no factory (or defaultFactory) is provided a new function is created when matching styles (addFactoryAndOverrideStylesToProtoChain, addStyleToProtoChain, applyFilter).
> This is a major source of unneeded memory allocations (== GC)
> The patch re-use a single function as the prototype is always reseted 
> This should be reviewed by an actionscript ninja ;-)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)