You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/02/22 18:46:28 UTC
[jira] Created: (DAEMON-133) The field SimpleDaemon.stopping is
accessed from multiple threads without synch.
The field SimpleDaemon.stopping is accessed from multiple threads without synch.
--------------------------------------------------------------------------------
Key: DAEMON-133
URL: https://issues.apache.org/jira/browse/DAEMON-133
Project: Commons Daemon
Issue Type: Bug
Reporter: Sebb
The field SimpleDaemon.stopping is accessed from multiple threads without synchronisation.
The field is access from the run() and stop() methods, and should either be made volatile, or should should be accessed from a synchronized block.
WIthout such synch, the run() method may never see the value set by the stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (DAEMON-133) The field SimpleDaemon.stopping
is accessed from multiple threads without synch.
Posted by Mladen Turk <mt...@apache.org>.
On 02/26/2010 06:19 PM, sebb wrote:
> On 26/02/2010, Mladen Turk<mt...@apache.org> wrote:
>> On 02/25/2010 10:30 PM, sebb wrote:
>>
>>>
>>> Quite a few JIRAs are shown as having been fixed for 1.0.1 when
>>> RELEASE-NOTES.txt shows that they were fixed for 1.0.2, for example:
>>>
>>> DAEMON-130, DAEMON-132
>>>
>>> I assume that the release notes are probably correct.
>>>
>>> OK if I fix JIRA?
>>>
>>>
>>
>> Sure, go for it.
>> Since it's been so long since 1.0.1, JIRA doesn't
>> perfectly reflects the actual changes.
>
> Huh? JIRA just records what it was told.
>
Right, and that's what I meant.
It just wasn't maintained properly.
> There are a still quite a few bugs marked Fixed but without Fix versions.
> That can be left as an exercise for later.
>
Sure.
Thanks
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jira] Updated: (DAEMON-133) The field SimpleDaemon.stopping is
accessed from multiple threads without synch.
Posted by sebb <se...@gmail.com>.
On 26/02/2010, Mladen Turk <mt...@apache.org> wrote:
> On 02/25/2010 10:30 PM, sebb wrote:
>
> >
> > Quite a few JIRAs are shown as having been fixed for 1.0.1 when
> > RELEASE-NOTES.txt shows that they were fixed for 1.0.2, for example:
> >
> > DAEMON-130, DAEMON-132
> >
> > I assume that the release notes are probably correct.
> >
> > OK if I fix JIRA?
> >
> >
>
> Sure, go for it.
> Since it's been so long since 1.0.1, JIRA doesn't
> perfectly reflects the actual changes.
Huh? JIRA just records what it was told.
Anyway, I've marked all the bugs listed in the release notes as fixed
in 1.0.2 with a fix version of 1.0.2. Some of them had been
incorrectly marked as fixed in 1.0.1 (which obviously does not make
sense if the bug is also reported against 1.0.1. Not sure why JIRA
does not complain...).
I removed some Fix versions from bugs marked as Invalid & Won't Fix as
a fix version does not make sense for them.
There are a still quite a few bugs marked Fixed but without Fix versions.
That can be left as an exercise for later.
> I plan to do some cleanup, deprecate dormant
> components and probably make another release
> within 6 months time frame.
>
> Regards
> --
> ^TM
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jira] Updated: (DAEMON-133) The field SimpleDaemon.stopping
is accessed from multiple threads without synch.
Posted by Mladen Turk <mt...@apache.org>.
On 02/25/2010 10:30 PM, sebb wrote:
>
> Quite a few JIRAs are shown as having been fixed for 1.0.1 when
> RELEASE-NOTES.txt shows that they were fixed for 1.0.2, for example:
>
> DAEMON-130, DAEMON-132
>
> I assume that the release notes are probably correct.
>
> OK if I fix JIRA?
>
Sure, go for it.
Since it's been so long since 1.0.1, JIRA doesn't
perfectly reflects the actual changes.
I plan to do some cleanup, deprecate dormant
components and probably make another release
within 6 months time frame.
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jira] Updated: (DAEMON-133) The field SimpleDaemon.stopping is
accessed from multiple threads without synch.
Posted by sebb <se...@gmail.com>.
On 25/02/2010, Sebb (JIRA) <ji...@apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/DAEMON-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
>
> Sebb updated DAEMON-133:
> ------------------------
>
> Affects Version/s: 1.0.1
> Fix Version/s: (was: 1.0.1)
> 1.0.2
>
>
Quite a few JIRAs are shown as having been fixed for 1.0.1 when
RELEASE-NOTES.txt shows that they were fixed for 1.0.2, for example:
DAEMON-130, DAEMON-132
I assume that the release notes are probably correct.
OK if I fix JIRA?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[jira] Updated: (DAEMON-133) The field SimpleDaemon.stopping is
accessed from multiple threads without synch.
Posted by "Mladen Turk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mladen Turk updated DAEMON-133:
-------------------------------
Fix Version/s: (was: 1.0.2)
1.0.1
> The field SimpleDaemon.stopping is accessed from multiple threads without synch.
> --------------------------------------------------------------------------------
>
> Key: DAEMON-133
> URL: https://issues.apache.org/jira/browse/DAEMON-133
> Project: Commons Daemon
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 1.0.1
>
>
> The field SimpleDaemon.stopping is accessed from multiple threads without synchronisation.
> The field is access from the run() and stop() methods, and should either be made volatile, or should should be accessed from a synchronized block.
> WIthout such synch, the run() method may never see the value set by the stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DAEMON-133) The field SimpleDaemon.stopping is
accessed from multiple threads without synch.
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved DAEMON-133.
-------------------------
Resolution: Fixed
Fix Version/s: 1.0.2
URL: http://svn.apache.org/viewvc?rev=914997&view=rev
Log:
Ensure access to stopping flag is correctly published across threads
> The field SimpleDaemon.stopping is accessed from multiple threads without synch.
> --------------------------------------------------------------------------------
>
> Key: DAEMON-133
> URL: https://issues.apache.org/jira/browse/DAEMON-133
> Project: Commons Daemon
> Issue Type: Bug
> Reporter: Sebb
> Fix For: 1.0.2
>
>
> The field SimpleDaemon.stopping is accessed from multiple threads without synchronisation.
> The field is access from the run() and stop() methods, and should either be made volatile, or should should be accessed from a synchronized block.
> WIthout such synch, the run() method may never see the value set by the stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DAEMON-133) The field SimpleDaemon.stopping is
accessed from multiple threads without synch.
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DAEMON-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated DAEMON-133:
------------------------
Affects Version/s: 1.0.1
Fix Version/s: (was: 1.0.1)
1.0.2
> The field SimpleDaemon.stopping is accessed from multiple threads without synch.
> --------------------------------------------------------------------------------
>
> Key: DAEMON-133
> URL: https://issues.apache.org/jira/browse/DAEMON-133
> Project: Commons Daemon
> Issue Type: Bug
> Affects Versions: 1.0.1
> Reporter: Sebb
> Fix For: 1.0.2
>
>
> The field SimpleDaemon.stopping is accessed from multiple threads without synchronisation.
> The field is access from the run() and stop() methods, and should either be made volatile, or should should be accessed from a synchronized block.
> WIthout such synch, the run() method may never see the value set by the stop() method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.