You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/16 16:58:45 UTC
[GitHub] [airflow] josh-fell opened a new pull request #20347: Move source_objects datatype check out of GCSToBigQueryOperator.__init__
josh-fell opened a new pull request #20347:
URL: https://github.com/apache/airflow/pull/20347
Closes: #20333
Currently there is a datatype check on `source_objects` within the `GCSToBigQueryOperator.__init__()` method. This is a template field for the operator. If a user tries to pass in an `XCom` value that will be rendered as a list (i.e. `render_template_as_native_obj=True` at the DAG level), the datatype check incorrectly assumes the value is a string and wraps the value in a list. When the `XCom` value is then rendered during `execute()` the value becomes a `List[List]` instead of the desired `List` type.
Moving this datatype check into the `execute()` method of the operator will allow any template rendering to occur before the check is performed.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20347: Move source_objects datatype check out of GCSToBigQueryOperator.__init__
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20347:
URL: https://github.com/apache/airflow/pull/20347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20347: Move source_objects datatype check out of GCSToBigQueryOperator.__init__
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20347:
URL: https://github.com/apache/airflow/pull/20347#issuecomment-996174912
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org