You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/27 02:13:08 UTC

[GitHub] [incubator-seatunnel] ruanwenjun opened a new issue #1584: [Feature][sql] rename seatunnel-core-sql to seatunnel-core-flink

ruanwenjun opened a new issue #1584:
URL: https://github.com/apache/incubator-seatunnel/issues/1584


   ### Search before asking
   
   - [X] I had searched in the [feature](https://github.com/apache/incubator-seatunnel/issues?q=is%3Aissue+label%3A%22Feature%22) and found no similar feature requirement.
   
   
   ### Description
   
   We have `seatunnel-core-flink`, `seatunnel-core-spark`, `seatunnel-core-sql` modules in core module.
   This sometimes make confusion, since right now `seatunnel-core-sql` is just support flink engine, and will use flink to run the sql task. It not supports spark.
   
   I suggest moving the code from `seatunnel-core-sql` module to `seatunnel-core-flink`.
   
   We need to add a new `Command` name `FlinkSqlExecuteCommand` and add a new Execution named `FlinkSqlExecution` to execute the command. 
   
   ### Usage Scenario
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on issue #1584: [Feature][sql] Move seatunnel-core-sql to seatunnel-core-flink

Posted by GitBox <gi...@apache.org>.
BenJFan commented on issue #1584:
URL: https://github.com/apache/incubator-seatunnel/issues/1584#issuecomment-1080104844


   > > Why not rename seatunnel-core-sql to seatunnel-sql-flink？So If we support spark sql, we can use name seatunnel-sql-spark.
   > 
   > Thanks for your advice, but I think it might be better to remove the current `sql` module? Since `sql` is just a sub-task type like `streaming`, `batch`, `structuredstreaming`.
   
   It seem like fine


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs closed issue #1584: [Feature][sql] Move seatunnel-core-sql to seatunnel-core-flink

Posted by GitBox <gi...@apache.org>.
CalvinKirs closed issue #1584:
URL: https://github.com/apache/incubator-seatunnel/issues/1584


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] BenJFan commented on issue #1584: [Feature][sql] Move seatunnel-core-sql to seatunnel-core-flink

Posted by GitBox <gi...@apache.org>.
BenJFan commented on issue #1584:
URL: https://github.com/apache/incubator-seatunnel/issues/1584#issuecomment-1079918336


   Why not rename seatunnel-core-sql to seatunnel-sql-flink？So If we support spark sql, we can use name seatunnel-sql-spark.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on issue #1584: [Feature][sql] Move seatunnel-core-sql to seatunnel-core-flink

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on issue #1584:
URL: https://github.com/apache/incubator-seatunnel/issues/1584#issuecomment-1079921571


   > Why not rename seatunnel-core-sql to seatunnel-sql-flink？So If we support spark sql, we can use name seatunnel-sql-spark.
   
   Thanks for your advice, but I think it might be better to remove the current `sql` module? Since `sql` is just a sub-task type like `streaming`, `batch`, `structuredstreaming`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org