You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/26 06:40:22 UTC
[GitHub] [hudi] zhangyue19921010 opened a new pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
zhangyue19921010 opened a new pull request #3545:
URL: https://github.com/apache/hudi/pull/3545
https://issues.apache.org/jira/browse/HUDI-2355
## What is the purpose of the pull request
After https://github.com/apache/hudi/pull/3310 merged, replaced data file is cleaned in cleaner service. But if replacecommit file deleted by archival, cleaner service can not delete the replaced data file anymore.
## Brief change log
Just change the execution order between cleaner and archival services.
-> cleaner service starts first then archival service works.
For sync clean, we trigger clean first. After clean finished then trigger archival service
For async clean, we will wait cleaner service finished in `postCommit` function and then trigger archival service.
This change is tested on dev env.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#issuecomment-906138986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1909",
"triggerID" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"triggerType" : "PUSH"
}, {
"hash" : "c5a338b609c436621b81c4e55e6bf378a218e8c6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c5a338b609c436621b81c4e55e6bf378a218e8c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7c1e9665c61ac30016c6519ce32945cc27b2a79 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1909)
* c5a338b609c436621b81c4e55e6bf378a218e8c6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#issuecomment-907011557
Without this patch, added UT will fail. And replaced data file can't be deleted by sync/async cleaner because of corresponding replacecommits archived .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on a change in pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on a change in pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#discussion_r697234404
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -434,10 +434,10 @@ protected void postCommit(HoodieTable<T, I, K, O> table, HoodieCommitMetadata me
// Delete the marker directory for the instant.
WriteMarkersFactory.get(config.getMarkersType(), table, instantTime)
.quietDeleteMarkerDir(context, config.getMarkersDeleteParallelism());
+ autoCleanOnCommit();
Review comment:
Sure thing. Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#issuecomment-906138986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7c1e9665c61ac30016c6519ce32945cc27b2a79 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] zhangyue19921010 commented on pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
zhangyue19921010 commented on pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#issuecomment-906196522
The failed UT job is passed on my local env and Also passed in Azure.
Will re-trigger travis soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#issuecomment-906138986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1909",
"triggerID" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"triggerType" : "PUSH"
}, {
"hash" : "c5a338b609c436621b81c4e55e6bf378a218e8c6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1923",
"triggerID" : "c5a338b609c436621b81c4e55e6bf378a218e8c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7c1e9665c61ac30016c6519ce32945cc27b2a79 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1909)
* c5a338b609c436621b81c4e55e6bf378a218e8c6 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1923)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#issuecomment-906138986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1909",
"triggerID" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"triggerType" : "PUSH"
}, {
"hash" : "c5a338b609c436621b81c4e55e6bf378a218e8c6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1923",
"triggerID" : "c5a338b609c436621b81c4e55e6bf378a218e8c6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c5a338b609c436621b81c4e55e6bf378a218e8c6 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1923)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan merged pull request #3545: [HUDI-2355][Bug]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
nsivabalan merged pull request #3545:
URL: https://github.com/apache/hudi/pull/3545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] lw309637554 commented on a change in pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
lw309637554 commented on a change in pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#discussion_r696575891
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -434,10 +434,10 @@ protected void postCommit(HoodieTable<T, I, K, O> table, HoodieCommitMetadata me
// Delete the marker directory for the instant.
WriteMarkersFactory.get(config.getMarkersType(), table, instantTime)
.quietDeleteMarkerDir(context, config.getMarkersDeleteParallelism());
+ autoCleanOnCommit();
Review comment:
can we add a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#issuecomment-906138986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1909",
"triggerID" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7c1e9665c61ac30016c6519ce32945cc27b2a79 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1909)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3545: [HUDI-2355]Archive service executed after cleaner finished.
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3545:
URL: https://github.com/apache/hudi/pull/3545#issuecomment-906138986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1909",
"triggerID" : "f7c1e9665c61ac30016c6519ce32945cc27b2a79",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f7c1e9665c61ac30016c6519ce32945cc27b2a79 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1909)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org