You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org> on 2021/03/11 23:58:41 UTC
[kudu-CR] [master] Check for 'last known addr' field when adding master
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17176
Change subject: [master] Check for 'last_known_addr' field when adding master
......................................................................
[master] Check for 'last_known_addr' field when adding master
In a single master configuration, the 'last_known_addr' field
may not be populated in the Raft config and Raft implementation will
throw an error on adding a new master which is not actionable.
Hence adding an explicit check with an actionable error message
to fix the problem.
Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
---
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master.cc
2 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/17176/1
--
To view, visit http://gerrit.cloudera.org:8080/17176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
Gerrit-Change-Number: 17176
Gerrit-PatchSet: 1
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
[kudu-CR] [master] Check for 'last known addr' field when adding master
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17176 )
Change subject: [master] Check for 'last_known_addr' field when adding master
......................................................................
Patch Set 2: Code-Review+1
Nothing to add to Mahesh's feedback.
--
To view, visit http://gerrit.cloudera.org:8080/17176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
Gerrit-Change-Number: 17176
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Mar 2021 19:32:50 +0000
Gerrit-HasComments: No
[kudu-CR] [master] Check for 'last known addr' field when adding master
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17176 )
Change subject: [master] Check for 'last_known_addr' field when adding master
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
overall lgtm, just a few nits about the readability of the comment for the new block of code in master.cc
http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc
File src/kudu/master/master.cc:
http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc@515
PS2, Line 515: // If a new master is being added to a single master configuration check that
nit: add a comma after 'configuration' to increase comment's readibility.
http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc@516
PS2, Line 516: // the current leader master has the 'last_known_addr' populated otherwise
nit: add a period after 'populated' and subsequently capitalize 'otherwise'.
--
To view, visit http://gerrit.cloudera.org:8080/17176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
Gerrit-Change-Number: 17176
Gerrit-PatchSet: 2
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Mar 2021 19:06:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] [master] Check for 'last known addr' field when adding master
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17176 )
Change subject: [master] Check for 'last_known_addr' field when adding master
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
Gerrit-Change-Number: 17176
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 18:26:30 +0000
Gerrit-HasComments: No
[kudu-CR] [master] Check for 'last known addr' field when adding master
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17176 )
Change subject: [master] Check for 'last_known_addr' field when adding master
......................................................................
[master] Check for 'last_known_addr' field when adding master
In a single master configuration, the 'last_known_addr' field
may not be populated in the Raft config and Raft implementation will
throw an error on adding a new master which is not actionable.
Hence adding an explicit check with an actionable error message
to fix the problem.
Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
Reviewed-on: http://gerrit.cloudera.org:8080/17176
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master.cc
2 files changed, 21 insertions(+), 2 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
Gerrit-Change-Number: 17176
Gerrit-PatchSet: 4
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [master] Check for 'last known addr' field when adding master
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17176
to look at the new patch set (#3).
Change subject: [master] Check for 'last_known_addr' field when adding master
......................................................................
[master] Check for 'last_known_addr' field when adding master
In a single master configuration, the 'last_known_addr' field
may not be populated in the Raft config and Raft implementation will
throw an error on adding a new master which is not actionable.
Hence adding an explicit check with an actionable error message
to fix the problem.
Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
---
M src/kudu/master/dynamic_multi_master-test.cc
M src/kudu/master/master.cc
2 files changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/17176/3
--
To view, visit http://gerrit.cloudera.org:8080/17176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
Gerrit-Change-Number: 17176
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] [master] Check for 'last known addr' field when adding master
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17176 )
Change subject: [master] Check for 'last_known_addr' field when adding master
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc
File src/kudu/master/master.cc:
http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc@515
PS2, Line 515: // If a new master is being added to a single master configuration, check that
> nit: add a comma after 'configuration' to increase comment's readibility.
Done
http://gerrit.cloudera.org:8080/#/c/17176/2/src/kudu/master/master.cc@516
PS2, Line 516: // the current leader master has the 'last_known_addr' populated. Otherwise
> nit: add a period after 'populated' and subsequently capitalize 'otherwise'
Done
--
To view, visit http://gerrit.cloudera.org:8080/17176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic991c82acbb2a2149f647b5c1a5b323fecb958cb
Gerrit-Change-Number: 17176
Gerrit-PatchSet: 3
Gerrit-Owner: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 18:01:32 +0000
Gerrit-HasComments: Yes