You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by omkreddy <gi...@git.apache.org> on 2016/09/16 07:18:50 UTC
[GitHub] storm pull request #1686: STORM-2098: DruidBeamBolt: Pass DruidConfig.Builde...
GitHub user omkreddy opened a pull request:
https://github.com/apache/storm/pull/1686
STORM-2098: DruidBeamBolt: Pass DruidConfig.Builder as constructor argument
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omkreddy/storm druid-changes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1686.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1686
----
commit 2a3e035105755ac4462d311c50e179866c6f348f
Author: Manikumar Reddy O <ma...@gmail.com>
Date: 2016-09-16T06:24:49Z
STORM-2098: DruidBeamBolt: Pass DruidConfig.Builder as constructor argument
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1686: STORM-2098: DruidBeamBolt: Pass DruidConfig.Builde...
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1686#discussion_r79133341
--- Diff: external/storm-druid/src/test/java/org/apache/storm/druid/SampleDruidBoltTopology.java ---
@@ -52,11 +52,11 @@ public static void main(String[] args) throws Exception {
topologyBuilder.setSpout("event-gen", new SimpleSpout(), 5);
DruidBeamFactory druidBeamFactory = new SampleDruidBeamFactoryImpl(new HashMap<String, Object>());
- DruidConfig druidConfig = DruidConfig.newBuilder().discardStreamId(DruidConfig.DEFAULT_DISCARD_STREAM_ID).build();
+ DruidConfig.Builder bulder = DruidConfig.newBuilder().discardStreamId(DruidConfig.DEFAULT_DISCARD_STREAM_ID);
--- End diff --
typo nit: variable name should be `builder`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1686: STORM-2098: DruidBeamBolt: Pass DruidConfig.Builde...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1686
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1686: STORM-2098: DruidBeamBolt: Pass DruidConfig.Builder as co...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1686
+1 on this, but it might be better for Flux to handle builder method, just like Spring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1686: STORM-2098: DruidBeamBolt: Pass DruidConfig.Builder as co...
Posted by satishd <gi...@git.apache.org>.
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/1686
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1686: STORM-2098: DruidBeamBolt: Pass DruidConfig.Builde...
Posted by omkreddy <gi...@git.apache.org>.
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/1686#discussion_r79139660
--- Diff: external/storm-druid/src/test/java/org/apache/storm/druid/SampleDruidBoltTopology.java ---
@@ -52,11 +52,11 @@ public static void main(String[] args) throws Exception {
topologyBuilder.setSpout("event-gen", new SimpleSpout(), 5);
DruidBeamFactory druidBeamFactory = new SampleDruidBeamFactoryImpl(new HashMap<String, Object>());
- DruidConfig druidConfig = DruidConfig.newBuilder().discardStreamId(DruidConfig.DEFAULT_DISCARD_STREAM_ID).build();
+ DruidConfig.Builder bulder = DruidConfig.newBuilder().discardStreamId(DruidConfig.DEFAULT_DISCARD_STREAM_ID);
--- End diff --
Thanks for the review. Updated the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1686: STORM-2098: DruidBeamBolt: Pass DruidConfig.Builder as co...
Posted by omkreddy <gi...@git.apache.org>.
Github user omkreddy commented on the issue:
https://github.com/apache/storm/pull/1686
@satishd pinging for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---