You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mnovak <gi...@git.apache.org> on 2015/05/28 17:05:21 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-125 Shared backup server wi...
GitHub user mnovak opened a pull request:
https://github.com/apache/activemq-artemis/pull/5
ARTEMIS-125 Shared backup server with disabled scale down policy does…
… not activate.
If standalone backup server with shared has defined scale-down policy
but it's disabled then backup does not activate. Problem is that
server is checking only whether scale down is defined but if it's
enabled. This causes that server.stop() is called and backup does
not activate.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mnovak/activemq-artemis check-scale-down-policy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit 73c7fc86fc6901b1dea0b0a2a096ca7c38508fd6
Author: mnovak <mn...@redhat.com>
Date: 2015-05-28T14:53:31Z
ARTEMIS-125 Shared backup server with disabled scale down policy does not activate itself.
If standalone backup server with shared has defined scale-down policy
but it's disabled then backup does not activate. Problem is that
server is checking only whether scale down is defined but if it's
enabled. This causes that server.stop() is called and backup does
not activate.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-125 Shared backup server wi...
Posted by mnovak <gi...@git.apache.org>.
Github user mnovak commented on the pull request:
https://github.com/apache/activemq-artemis/pull/5#issuecomment-106701602
Did not notice that It's merged already. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-125 Shared backup server wi...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/5#issuecomment-106423466
@mnovak I had to do some rebasing (Justin changed some API) but I merged this already.
Make sure you rebase your branch now as it's quite changed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-125 Shared backup server wi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-125 Shared backup server wi...
Posted by mnovak <gi...@git.apache.org>.
Github user mnovak commented on the pull request:
https://github.com/apache/activemq-artemis/pull/5#issuecomment-106697030
Ok, I'll rebase and try again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---