You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Matt Foley (JIRA)" <ji...@apache.org> on 2011/05/04 00:05:03 UTC
[jira] [Created] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery since HDFS-1052
Recurring failures in TestDFSStorageStateRecovery since HDFS-1052
-----------------------------------------------------------------
Key: HDFS-1884
URL: https://issues.apache.org/jira/browse/HDFS-1884
Project: Hadoop HDFS
Issue Type: Sub-task
Reporter: Matt Foley
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery due to HADOOP-7146
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-1884:
---------------------------------
Attachment: hdfs-1884.1.patch
Rebased patch against trunk.
> Recurring failures in TestDFSStorageStateRecovery due to HADOOP-7146
> --------------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch, hdfs-1884.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery since HDFS-1052
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13036591#comment-13036591 ]
Todd Lipcon commented on HDFS-1884:
-----------------------------------
Anyone working on this? It's a shame our build has been broken for a full 3 weeks since federation was merged.
> Recurring failures in TestDFSStorageStateRecovery since HDFS-1052
> -----------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1884) Improve TestDFSStorageStateRecovery
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-1884:
------------------------------
Summary: Improve TestDFSStorageStateRecovery (was: Recurring failures in TestDFSStorageStateRecovery due to HADOOP-7146)
> Improve TestDFSStorageStateRecovery
> -----------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch, hdfs-1884.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Improve TestDFSStorageStateRecovery
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040994#comment-13040994 ]
Hudson commented on HDFS-1884:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #696 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/696/])
HDFS-1884. Improve TestDFSStorageStateRecovery to properly throw in the case of errors. Contributed by Aaron T. Myers.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128987
Files :
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSStorageStateRecovery.java
* /hadoop/hdfs/trunk/CHANGES.txt
> Improve TestDFSStorageStateRecovery
> -----------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1884.0.patch, hdfs-1884.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery since HDFS-1052
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028464#comment-13028464 ]
Matt Foley commented on HDFS-1884:
----------------------------------
The following test has failed on all or most PreCommit-HDFS-Build builds since #427, but not before that. #427 was the build for HDFS-1052.
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery.testBlockPoolStorageStates 427-446
> Recurring failures in TestDFSStorageStateRecovery since HDFS-1052
> -----------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1884) Improve TestDFSStorageStateRecovery
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HDFS-1884:
------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1. Committed to trunk. Thanks, Aaron.
> Improve TestDFSStorageStateRecovery
> -----------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1884.0.patch, hdfs-1884.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery due to HADOOP-7146
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040107#comment-13040107 ]
Hadoop QA commented on HDFS-1884:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479960/hdfs-1884.0.patch
against trunk revision 1128009.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/643//console
This message is automatically generated.
> Recurring failures in TestDFSStorageStateRecovery due to HADOOP-7146
> --------------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery due to HADOOP-7146
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-1884:
-----------------------------
Description: Changing summary to make it more informative in the HDFS-1852 roll-up.
Summary: Recurring failures in TestDFSStorageStateRecovery due to HADOOP-7146 (was: Recurring failures in TestDFSStorageStateRecovery since HDFS-1052)
> Recurring failures in TestDFSStorageStateRecovery due to HADOOP-7146
> --------------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch
>
>
> Changing summary to make it more informative in the HDFS-1852 roll-up.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery due to HADOOP-7146
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Foley updated HDFS-1884:
-----------------------------
Description: (was: Changing summary to make it more informative in the HDFS-1852 roll-up.)
> Recurring failures in TestDFSStorageStateRecovery due to HADOOP-7146
> --------------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery since HDFS-1052
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037114#comment-13037114 ]
Aaron T. Myers commented on HDFS-1884:
--------------------------------------
It is not. Note that the test implies both that it should and should not be. The original version has {{assert(...)}}s right after the statement that should theoretically be throwing, which wouldn't be reached if it were in fact throwing. Perhaps it should in fact be throwing, but in that case we should be putting {{fail(...)}}s right after the {{cluster.startDataNodes(...)}} calls, and the asserts in the {{catch(...)}} clauses.
> Recurring failures in TestDFSStorageStateRecovery since HDFS-1052
> -----------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery due to HADOOP-7146
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040435#comment-13040435 ]
Aaron T. Myers commented on HDFS-1884:
--------------------------------------
The only test which failed was {{TestFiDataTransferProtocol2}}. I just ran this test locally on my box and it passed just fine. I'm betting the failure was unrelated.
> Recurring failures in TestDFSStorageStateRecovery due to HADOOP-7146
> --------------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch, hdfs-1884.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery due to HADOOP-7146
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-1884:
---------------------------------
Status: Patch Available (was: Open)
> Recurring failures in TestDFSStorageStateRecovery due to HADOOP-7146
> --------------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Improve TestDFSStorageStateRecovery
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041111#comment-13041111 ]
Hudson commented on HDFS-1884:
------------------------------
Integrated in Hadoop-Hdfs-trunk #682 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/682/])
HDFS-1884. Improve TestDFSStorageStateRecovery to properly throw in the case of errors. Contributed by Aaron T. Myers.
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128987
Files :
* /hadoop/hdfs/trunk/src/test/hdfs/org/apache/hadoop/hdfs/TestDFSStorageStateRecovery.java
* /hadoop/hdfs/trunk/CHANGES.txt
> Improve TestDFSStorageStateRecovery
> -----------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Fix For: 0.23.0
>
> Attachments: hdfs-1884.0.patch, hdfs-1884.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery since HDFS-1052
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers reassigned HDFS-1884:
------------------------------------
Assignee: Aaron T. Myers
> Recurring failures in TestDFSStorageStateRecovery since HDFS-1052
> -----------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery since HDFS-1052
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037009#comment-13037009 ]
Aaron T. Myers commented on HDFS-1884:
--------------------------------------
@Todd: I'll take a look at it.
> Recurring failures in TestDFSStorageStateRecovery since HDFS-1052
> -----------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery since HDFS-1052
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13037106#comment-13037106 ]
Todd Lipcon commented on HDFS-1884:
-----------------------------------
So cluster.startDataNodes isn't throwing even though the test seems to claim it should be?
> Recurring failures in TestDFSStorageStateRecovery since HDFS-1052
> -----------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery since HDFS-1052
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron T. Myers updated HDFS-1884:
---------------------------------
Attachment: hdfs-1884.0.patch
Patch which fixes up the test a little bit to make it easier to debug in the future.
> Recurring failures in TestDFSStorageStateRecovery since HDFS-1052
> -----------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1884) Recurring failures in
TestDFSStorageStateRecovery due to HADOOP-7146
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040365#comment-13040365 ]
Hadoop QA commented on HDFS-1884:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12480672/hdfs-1884.1.patch
against trunk revision 1128393.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/648//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/648//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/648//console
This message is automatically generated.
> Recurring failures in TestDFSStorageStateRecovery due to HADOOP-7146
> --------------------------------------------------------------------
>
> Key: HDFS-1884
> URL: https://issues.apache.org/jira/browse/HDFS-1884
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Matt Foley
> Assignee: Aaron T. Myers
> Attachments: hdfs-1884.0.patch, hdfs-1884.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira