You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "cfmcgrady (via GitHub)" <gi...@apache.org> on 2023/10/24 15:44:24 UTC
[PR] Revert "[CELEBORN-255] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics" [incubator-celeborn]
cfmcgrady opened a new pull request, #2039:
URL: https://github.com/apache/incubator-celeborn/pull/2039
…Rpcs and outstandingPushes to metrics"
This reverts commit 23ecb21d21116757fbbe1f5423725a2b3763973e.
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[CELEBORN-255] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics" [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2039:
URL: https://github.com/apache/incubator-celeborn/pull/2039#issuecomment-1778427396
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2039?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2039](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2039?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (45de29d) into [branch-0.3](https://app.codecov.io/gh/apache/incubator-celeborn/commit/265805a532bce93796791d0056a547cfb795daa5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (265805a) will **decrease** coverage by `0.03%`.
> The diff coverage is `57.15%`.
```diff
@@ Coverage Diff @@
## branch-0.3 #2039 +/- ##
==============================================
- Coverage 46.12% 46.08% -0.03%
==============================================
Files 165 165
Lines 10431 10416 -15
Branches 970 968 -2
==============================================
- Hits 4810 4799 -11
+ Misses 5299 5298 -1
+ Partials 322 319 -3
```
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2039?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/celeborn/common/network/TransportContext.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2039?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9UcmFuc3BvcnRDb250ZXh0LmphdmE=) | `81.82% <100.00%> (ø)` | |
| [...eleborn/common/metrics/source/AbstractSource.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2039?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3Mvc291cmNlL0Fic3RyYWN0U291cmNlLnNjYWxh) | `35.75% <ø> (-0.82%)` | :arrow_down: |
| [...ommon/network/client/TransportResponseHandler.java](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2039?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0UmVzcG9uc2VIYW5kbGVyLmphdmE=) | `53.65% <50.00%> (-2.00%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2039/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[CELEBORN-255] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics" [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady closed pull request #2039: Revert "[CELEBORN-255] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics"
URL: https://github.com/apache/incubator-celeborn/pull/2039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "[CELEBORN-255] Add counter of outstandingFetches, outstandingRpcs and outstandingPushes to metrics" [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2039:
URL: https://github.com/apache/incubator-celeborn/pull/2039#issuecomment-1778457350
thanks, merging to branch-0.3(v0.3.2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org