[GitHub] [incubator-pinot] zhangloo333 commented on a change in pull request #6551: [TE]: fix eslint reported issue under the authenticators, helpers, and mirage folder

[GitBox <gi...@apache.org>]

zhangloo333 commented on a change in pull request #6551:
URL: https://github.com/apache/incubator-pinot/pull/6551#discussion_r571265862



##########
File path: thirdeye/thirdeye-frontend/app/helpers/compute-color.js
##########
@@ -11,9 +11,8 @@ export function computeColor([value = 0]) {
 
   if (value > 0) {
     return `rgba(0,0,234,${opacity})`;
-  } else{
-    return `rgba(234,0,0,${opacity})`;
   }
+  return `rgba(234,0,0,${opacity})`;

Review comment:
       Yes, it could be. I haven't changed it because my purpose is fixing eslint error in the codebase and changing the code structure will involve more risk. I need to test it again. For this suggestion, I can change it because the logic is simple. Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org