You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com> on 2008/02/02 22:09:24 UTC
[PATCH] Delete svn_client_propget3 and rename svn_client_propget4 to svn_client_propget3
2008-02-02 19:18:43 Barry Scott napisał(a):
> I'm reading svn_client.h to find the new API for 1.5 and noticed that
> svn_client_propget3 is supposed to be in 1.4. But its not listed in
> the svn_client.h in the 1.4.6 source tar ball.
>
> Was it in fact added for 1.5 as well as propget4?
Yes. It was added in r26745.
[[[
Delete svn_client_propget3 and rename svn_client_propget4 to
svn_client_propget3.
* subversion/include/svn_client.h
(svn_client_propget3): Delete and recreate from ...
(svn_client_propget4): ... here.
* subversion/libsvn_client/prop_commands.c
(svn_client_propget3): Delete and recreate from ...
(svn_client_propget4): ... here.
(remote_propget): Update doc string.
(svn_client_propget2): Update call to svn_client_propget3.
* subversion/libsvn_client/client.h
(svn_client__get_prop_from_wc): Update doc string.
* subversion/svn/propedit-cmd.c
(svn_cl__propedit):
* subversion/svn/propget-cmd.c
(svn_cl__propget):
* subversion/bindings/javahl/native/SVNClient.cpp
(SVNClient::propertyGet):
Call svn_client_propget3.
Found by: Barry Scott <ba...@barrys-emacs.org>
]]]
I have tested this patch and it seems to work.
--
Arfrever Frehtes Taifersar Arahesis
Re: [PATCH] Delete svn_client_propget3 and rename svn_client_propget4 to svn_client_propget3
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-02-02 23:09:01 Arfrever Frehtes Taifersar Arahesis napisał(a):
> 2008-02-02 19:18:43 Barry Scott napisał(a):
> > I'm reading svn_client.h to find the new API for 1.5 and noticed that
> > svn_client_propget3 is supposed to be in 1.4. But its not listed in
> > the svn_client.h in the 1.4.6 source tar ball.
> >
> > Was it in fact added for 1.5 as well as propget4?
>
> Yes. It was added in r26745.
I meant:
svn_client_propget4 was added in r26745.
svn_client_propget3 was added in r21887.
1.4.x branch was created in r19524.
--
Arfrever Frehtes Taifersar Arahesis
Re: [PATCH] Delete svn_client_propget3 and rename svn_client_propget4
to svn_client_propget3
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-02-02 19:18:43 Barry Scott napisał(a):
>> I'm reading svn_client.h to find the new API for 1.5 and noticed that
>> svn_client_propget3 is supposed to be in 1.4. But its not listed in
>> the svn_client.h in the 1.4.6 source tar ball.
>>
>> Was it in fact added for 1.5 as well as propget4?
>
> Yes. It was added in r26745.
>
> [[[
> Delete svn_client_propget3 and rename svn_client_propget4 to
> svn_client_propget3.
>
> * subversion/include/svn_client.h
> (svn_client_propget3): Delete and recreate from ...
> (svn_client_propget4): ... here.
>
> * subversion/libsvn_client/prop_commands.c
> (svn_client_propget3): Delete and recreate from ...
> (svn_client_propget4): ... here.
> (remote_propget): Update doc string.
> (svn_client_propget2): Update call to svn_client_propget3.
>
> * subversion/libsvn_client/client.h
> (svn_client__get_prop_from_wc): Update doc string.
>
> * subversion/svn/propedit-cmd.c
> (svn_cl__propedit):
> * subversion/svn/propget-cmd.c
> (svn_cl__propget):
> * subversion/bindings/javahl/native/SVNClient.cpp
> (SVNClient::propertyGet):
> Call svn_client_propget3.
>
> Found by: Barry Scott <ba...@barrys-emacs.org>
> ]]]
>
> I have tested this patch and it seems to work.
Committed, with a couple of whitespace tweaks, in r29208. Also
nominated for backport to 1.5.x. Thanks!
-Hyrum
Re: [PATCH] Delete svn_client_propget3 and rename svn_client_propget4 to svn_client_propget3
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
Could anybody review this patch?
It probably should be backported to 1.5.x branch.
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=134830
[[[
Delete svn_client_propget3 and rename svn_client_propget4 to
svn_client_propget3.
* subversion/include/svn_client.h
(svn_client_propget3): Delete and recreate from ...
(svn_client_propget4): ... here.
* subversion/libsvn_client/prop_commands.c
(svn_client_propget3): Delete and recreate from ...
(svn_client_propget4): ... here.
(remote_propget): Update doc string.
(svn_client_propget2): Update call to svn_client_propget3.
* subversion/libsvn_client/client.h
(svn_client__get_prop_from_wc): Update doc string.
* subversion/svn/propedit-cmd.c
(svn_cl__propedit):
* subversion/svn/propget-cmd.c
(svn_cl__propget):
* subversion/bindings/javahl/native/SVNClient.cpp
(SVNClient::propertyGet):
Call svn_client_propget3.
Found by: Barry Scott <ba...@barrys-emacs.org>
Patch by: arfrever
]]]
--
Arfrever Frehtes Taifersar Arahesis