You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "deshanxiao (via GitHub)" <gi...@apache.org> on 2023/03/02 10:33:29 UTC
[GitHub] [orc] deshanxiao opened a new pull request, #1426: ORC-1381: Update .gitignore
deshanxiao opened a new pull request, #1426:
URL: https://github.com/apache/orc/pull/1426
### What changes were proposed in this pull request?
This PR aims to update .gitignore.
After this PR, we will exclude all orc and crc files in git except:
1.The file located in examples folder.
2. All java resources test orc files.
### Why are the changes needed?
To exclude the git file impact caused by the test orc file.
### How was this patch tested?
manual testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao closed pull request #1426: [Won't Do] ORC-1381: Update .gitignore
Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao closed pull request #1426: [Won't Do] ORC-1381: Update .gitignore
URL: https://github.com/apache/orc/pull/1426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1426: [Won't Do] ORC-1381: Update .gitignore
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1426:
URL: https://github.com/apache/orc/pull/1426#issuecomment-1461212756
Thank you for your decision, @deshanxiao .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1426: ORC-1381: Update .gitignore
Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1426:
URL: https://github.com/apache/orc/pull/1426#issuecomment-1452125914
Sure, the reason for this is that when I run the ORC example, the newly generated ORC file is not ignored by git. Generally speaking, git tends to ignore these binary files and process text files as much as possible. But I found that we have a lot of orc files that need to be used by test. So I added them to the whitelist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1426: ORC-1381: Update .gitignore
Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1426:
URL: https://github.com/apache/orc/pull/1426#issuecomment-1459556618
I'm not sure if it's worth adding gitignore in this scenario. Do you have any good suggestions? @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1426: ORC-1381: Update .gitignore
Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1426:
URL: https://github.com/apache/orc/pull/1426#issuecomment-1451652111
```
find . -name "*.orc"
```
```
./my-file.orc
./java/core/src/test/resources/orc_split_elim.orc
./java/core/src/test/resources/col.dot.orc
./java/core/src/test/resources/orc-file-dst-no-timezone.orc
./java/core/src/test/resources/orc-file-no-timezone.orc
./java/core/src/test/resources/orc-file-11-format.orc
./java/core/target/test-classes/orc_split_elim.orc
./java/core/target/test-classes/col.dot.orc
./java/core/target/test-classes/orc-file-dst-no-timezone.orc
./java/core/target/test-classes/orc-file-no-timezone.orc
./java/core/target/test-classes/orc-file-11-format.orc
./java/mapreduce/src/test/resources/acid5k.orc
./java/mapreduce/src/test/resources/aaa.orc
./java/mapreduce/target/test-classes/acid5k.orc
./examples/TestOrcFile.testWithoutIndex.orc
./examples/orc_split_elim.orc
./examples/TestOrcFile.testUnionAndTimestamp.orc
./examples/TestOrcFile.testMemoryManagementV11.orc
./examples/TestStringDictionary.testRowIndex.orc
./examples/complextypes_iceberg.orc
./examples/bad_bloom_filter_1.6.11.orc
./examples/TestOrcFile.testStringAndBinaryStatistics.orc
./examples/orc_split_elim_cpp.orc
./examples/orc_split_elim_new.orc
./examples/TestOrcFile.testDate1900.orc
./examples/TestOrcFile.test1.orc
./examples/orc_no_format.orc
./examples/TestOrcFile.columnProjection.orc
./examples/corrupt/missing_length_stream_in_string_dict.orc
./examples/corrupt/stripe_footer_bad_column_encodings.orc
./examples/corrupt/missing_blob_stream_in_string_dict.orc
./examples/corrupt/negative_dict_entry_lengths.orc
./examples/TestOrcFile.testSeek.orc
./examples/over1k_bloom.orc
./examples/TestVectorOrcFile.testLz4.orc
./examples/nulls-at-end-snappy.orc
./examples/TestOrcFile.testTimestamp.orc
./examples/TestOrcFile.emptyFile.orc
./examples/TestOrcFile.testSnappy.orc
./examples/orc_index_int_string.orc
./examples/TestOrcFile.metaData.orc
./examples/version1999.orc
./examples/TestOrcFile.testMemoryManagementV12.orc
./examples/bad_bloom_filter_1.6.0.orc
./examples/demo-11-none.orc
./examples/TestOrcFile.testSargSkipPickupGroupWithoutIndexJava.orc
./examples/TestOrcFile.testDate2038.orc
./examples/decimal.orc
./examples/TestOrcFile.testWithoutCompressionBlockSize.orc
./examples/demo-12-zlib.orc
./examples/TestOrcFile.testSargSkipPickupGroupWithoutIndexCPlusPlus.orc
./examples/decimal64_v2.orc
./examples/TestOrcFile.testPredicatePushdown.orc
./examples/zero.orc
./examples/decimal64_v2_cplusplus.orc
./examples/TestVectorOrcFile.testZstd.0.12.orc
./examples/encrypted/sample2.orc
./examples/encrypted/sample1.orc
./examples/orc-file-11-format.orc
./examples/TestOrcFile.testStripeLevelStats.orc
./examples/demo-11-zlib.orc
./examples/TestVectorOrcFile.testLzo.orc
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1426: ORC-1381: Update .gitignore
Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1426:
URL: https://github.com/apache/orc/pull/1426#issuecomment-1451652845
cc @guiyanakuang @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] deshanxiao commented on pull request #1426: [Won't Do] ORC-1381: Update .gitignore
Posted by "deshanxiao (via GitHub)" <gi...@apache.org>.
deshanxiao commented on PR #1426:
URL: https://github.com/apache/orc/pull/1426#issuecomment-1461212164
> Yes, unfortunately, I'm reluctant to hide these files. If you don't mind, shall we close this as `Won't Do`?
Thank you @dongjoon-hyun . Close the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #1426: ORC-1381: Update .gitignore
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1426:
URL: https://github.com/apache/orc/pull/1426#issuecomment-1460665321
Yes, unfortunately, I'm reluctant to hide these files. If you don't mind, shall we close this as `Won't Do`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org