You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2014/12/19 20:05:13 UTC

[jira] [Commented] (LUCENE-6127) fix mockanalyzer to not use asserts

    [ https://issues.apache.org/jira/browse/LUCENE-6127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253807#comment-14253807 ] 

Michael McCandless commented on LUCENE-6127:
--------------------------------------------

+1

Thank you for fixing TestCachingTokenFilter to be more precise in its check for an exception.

> fix mockanalyzer to not use asserts
> -----------------------------------
>
>                 Key: LUCENE-6127
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6127
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6127.patch
>
>
> Currently MockAnalyzer's checks are implemented with assert. But this is just for convenience, we should not rely upon asserts being turned on: this is the whole point of the class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org