You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@omid.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/01 23:25:01 UTC
[jira] [Commented] (OMID-87) Fix BatchPool initialization
[ https://issues.apache.org/jira/browse/OMID-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349481#comment-16349481 ]
ASF GitHub Bot commented on OMID-87:
------------------------------------
GitHub user francisco-perez-sorrosal opened a pull request:
https://github.com/apache/incubator-omid/pull/21
[OMID-87] Fix BatchPool initialization
Added config.setMaxIdle(poolSize + 1) to the configuration.
Added some tests to prove it works.
Change-Id: Idc32ffa8472e87defdc540abbb901cfba700eb05
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/francisco-perez-sorrosal/incubator-omid omid-87
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-omid/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit 7ccd2e0751e9fa8de765feda8a246fb927b5b670
Author: Francisco Perez-Sorrosal <fp...@...>
Date: 2018-02-01T23:19:09Z
[OMID-87] Fix BatchPool initialization
Added config.setMaxIdle(poolSize + 1) to the configuration.
Added some tests to prove it works.
Change-Id: Idc32ffa8472e87defdc540abbb901cfba700eb05
----
> Fix BatchPool initialization
> ----------------------------
>
> Key: OMID-87
> URL: https://issues.apache.org/jira/browse/OMID-87
> Project: Apache Omid
> Issue Type: Bug
> Affects Versions: 0.8.2.0
> Reporter: Francisco Perez-Sorrosal
> Assignee: Francisco Perez-Sorrosal
> Priority: Critical
> Labels: batch, batchpool, creation, fix
> Fix For: 0.9.0.0
>
>
> When initializing the ObjectPool for Batch java objects in BatchPoolModule.java, an Apache's GenericObjectPool is used. The pool configuration lacks the call to config.setMaxIdle(int), which provokes that when the Batch objects are returned to the ObjectPool during the pre-creation phase, those above the default max idle number of objects in the pool (which is 8 according to the [Apache documentation|https://commons.apache.org/proper/commons-pool/api-1.6/org/apache/commons/pool/impl/GenericObjectPool.html]) are destroyed.
> If at some point the TSO needs to access those Batch objects between 8 and the number specified in the Omid configuration (numConcurrentCTWriters), they will be created on the fly, which it was we want to avoid when pre-creating the ObjectPool during the TSO initialization.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)