You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Kamesh Jayachandran <ka...@collab.net> on 2006/10/09 06:50:15 UTC
Re: svn commit: r21837 - in branches/incomplete-directories: . subversion/tests/cmdline
kfogel@tigris.org wrote:
> Author: kfogel
> Date: Sun Oct 8 21:19:37 2006
> New Revision: 21837
>
> Log:
> On the incomplete-directories branch:
>
> * build.conf
> (test-scripts): Add depth_tests.py to the list.
>
> * subversion/tests/cmdline/depth_tests.py: New file.
> (depth_one_same_as_nonrecursive): New helper function.
> (depth_zero_checkout, depth_one_checkout, nonrecursive_checkout):
> New test functions.
> (test_list): Run the new tests as XFail.
>
> * subversion/tests/cmdline/checkout_tests.py
> (depth_one_checkout): Remove this test, reimplement in new file above.
>
>
> Added:
> branches/incomplete-directories/subversion/tests/cmdline/depth_tests.py (contents, props changed)
> Modified:
> branches/incomplete-directories/build.conf
>
> Modified: branches/incomplete-directories/build.conf
> URL: http://svn.collab.net/viewvc/svn/branches/incomplete-directories/build.conf?pathrev=21837&r1=21836&r2=21837
> ==============================================================================
> --- branches/incomplete-directories/build.conf (original)
> +++ branches/incomplete-directories/build.conf Sun Oct 8 21:19:37 2006
> @@ -89,6 +89,7 @@
> subversion/tests/cmdline/import_tests.py
> subversion/tests/cmdline/svnsync_tests.py
> subversion/tests/cmdline/authz_tests.py
> + subversion/tests/cmdline/depth_tests.py
>
> bdb-test-scripts =
>
>
> Added: branches/incomplete-directories/subversion/tests/cmdline/depth_tests.py
> URL: http://svn.collab.net/viewvc/svn/branches/incomplete-directories/subversion/tests/cmdline/depth_tests.py?pathrev=21837
> ==============================================================================
> --- (empty file)
> +++ branches/incomplete-directories/subversion/tests/cmdline/depth_tests.py Sun Oct 8 21:19:37 2006
> @@ -0,0 +1,114 @@
> +#!/usr/bin/env python
> +#
> +# depth_tests.py: Testing that operations work as expected at
> +# various depths (depth-0, depth-1, depth-infinity).
> +#
> +# Subversion is a tool for revision control.
> +# See http://subversion.tigris.org for more information.
> +#
> +# ====================================================================
> +# Copyright (c) 2000-2006 CollabNet. All rights reserved.
>
Should it not be only 2006?
> +#
> +# This software is licensed as described in the file COPYING, which
> +# you should have received as part of this distribution. The terms
> +# are also available at http://subversion.tigris.org/license-1.html.
> +# If newer versions of this license are posted there, you may use a
> +# newer version instead, at your option.
> +#
> +######################################################################
> +
> +# General modules
> +import sys, re, os, time
>
I could not see 'sys', 're', 'time' used anywhere in the script.
> +
> +# Our testing module
> +import svntest
> +from svntest import wc, SVNAnyOutput
> +
> +# (abbreviation)
> +Skip = svntest.testcase.Skip
>
I could not see 'Skip' used anywhere in the script.
> +XFail = svntest.testcase.XFail
> +Item = wc.StateItem
>
I could not see 'Item' used anywhere in the script.
> +XFail = svntest.testcase.XFail
>
Duplicate XFail?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r21837 - in branches/incomplete-directories: . subversion/tests/cmdline
Posted by Kamesh Jayachandran <ka...@collab.net>.
> Huh, I don't know how the duplicate XFail happened. The others are
> standard to have at the top of any test script, and I think they
> should be in this one even though they're not used right now, because
> they surely will be in the future.
>
> -Karl
>
>
Can you remove the duplicate XFail from depth_tests.py?
I will post the patch to remove the same from checkout_tests.py against
trunk. I could not see any other tests having this problem.
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r21837 - in branches/incomplete-directories: . subversion/tests/cmdline
Posted by Karl Fogel <kf...@google.com>.
Kamesh Jayachandran <ka...@collab.net> writes:
> You added one XFail as a part of your change r21179. svnmerge(r21307)
> of /trunk: 21257-21306 added the duplicate XFail.
> Hence we need to remove this duplicate XFail from both depth_tests.py
> and checkout_tests.py on incomplete-directories branch alone.
Thank you. Fixed in r21851.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r21837 - in branches/incomplete-directories: . subversion/tests/cmdline
Posted by Kamesh Jayachandran <ka...@collab.net>.
> Huh, I don't know how the duplicate XFail happened. The others are
> standard to have at the top of any test script, and I think they
> should be in this one even though they're not used right now, because
> they surely will be in the future.
>
> -Karl
>
>
You added one XFail as a part of your change r21179. svnmerge(r21307) of
/trunk: 21257-21306 added the duplicate XFail.
Hence we need to remove this duplicate XFail from both depth_tests.py
and checkout_tests.py on incomplete-directories branch alone.
With regards
Kamesh Jayachandran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r21837 - in branches/incomplete-directories: . subversion/tests/cmdline
Posted by Karl Fogel <kf...@google.com>.
Kamesh Jayachandran <ka...@collab.net> writes:
>> +++ branches/incomplete-directories/subversion/tests/cmdline/depth_tests.py Sun Oct 8 21:19:37 2006
>> @@ -0,0 +1,114 @@
>> +#!/usr/bin/env python
>> +#
>> +# depth_tests.py: Testing that operations work as expected at
>> +# various depths (depth-0, depth-1, depth-infinity).
>> +#
>> +# Subversion is a tool for revision control.
>> +# See http://subversion.tigris.org for more information.
>> +#
>> +# ====================================================================
>> +# Copyright (c) 2000-2006 CollabNet. All rights reserved.
>>
> Should it not be only 2006?
Good catch! Will fix, thanks.
>> +# This software is licensed as described in the file COPYING, which
>> +# you should have received as part of this distribution. The terms
>> +# are also available at http://subversion.tigris.org/license-1.html.
>> +# If newer versions of this license are posted there, you may use a
>> +# newer version instead, at your option.
>> +#
>> +######################################################################
>> +
>> +# General modules
>> +import sys, re, os, time
>>
> I could not see 'sys', 're', 'time' used anywhere in the script.
Heh. I copied this from checkout_tests.py, as you can probably tell.
Will fix.
>> +
>> +# Our testing module
>> +import svntest
>> +from svntest import wc, SVNAnyOutput
>> +
>> +# (abbreviation)
>> +Skip = svntest.testcase.Skip
>>
> I could not see 'Skip' used anywhere in the script.
>> +XFail = svntest.testcase.XFail
>> +Item = wc.StateItem
>>
> I could not see 'Item' used anywhere in the script.
>> +XFail = svntest.testcase.XFail
>>
> Duplicate XFail?
Huh, I don't know how the duplicate XFail happened. The others are
standard to have at the top of any test script, and I think they
should be in this one even though they're not used right now, because
they surely will be in the future.
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org