You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/09 08:49:42 UTC
[GitHub] [airflow] dgdelahera commented on pull request #23450: Add await all containers option to Kubernetes Pod Operator
dgdelahera commented on PR #23450:
URL: https://github.com/apache/airflow/pull/23450#issuecomment-1150849236
Hi @dstandish and @jedcunningham. Thank you for your review, and sorry for the delay, it's been a busy week. Going back to this PR, I have made a diagram to clarify it because I think that we can delete this function method call https://github.com/apache/airflow/blob/main/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py#L418. That point can only be reached when the base container has finished, so we don't need to wait until the pod has finished. This will continue working with single containers, and it will fix the behavior when running with sidecars.

Regarding the `delete_worker_pods` interaction, I think that the best way to do the `clean up` is to inspect the base container state (the one that it is executing the workload) instead of the pod state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org