You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/03/04 00:10:01 UTC
Review Request 44367: GEODE-1043: Changing modules-assembly dist
target to depend on assemble
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44367/
-----------------------------------------------------------
Review request for geode, Jens Deppe and Jinmei Liao.
Repository: geode
Description
-------
The geode-modules-assembly was causing all of the module tests to get
run when running installDist. This can slow down people that are just
trying to install the product without running tests, or trying to write
tests in the geode-assembly project.
Diffs
-----
extensions/geode-modules-assembly/build.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/44367/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 44367: GEODE-1043: Changing modules-assembly dist
target to depend on assemble
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44367/#review122095
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On March 3, 2016, 11:10 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44367/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 11:10 p.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The geode-modules-assembly was causing all of the module tests to get
> run when running installDist. This can slow down people that are just
> trying to install the product without running tests, or trying to write
> tests in the geode-assembly project.
>
>
> Diffs
> -----
>
> extensions/geode-modules-assembly/build.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44367/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 44367: GEODE-1043: Changing modules-assembly dist
target to depend on assemble
Posted by Jinmei Liao <ji...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44367/#review122315
-----------------------------------------------------------
Ship it!
Ship It!
- Jinmei Liao
On March 3, 2016, 11:10 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44367/
> -----------------------------------------------------------
>
> (Updated March 3, 2016, 11:10 p.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The geode-modules-assembly was causing all of the module tests to get
> run when running installDist. This can slow down people that are just
> trying to install the product without running tests, or trying to write
> tests in the geode-assembly project.
>
>
> Diffs
> -----
>
> extensions/geode-modules-assembly/build.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/44367/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>