You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "dentiny (via GitHub)" <gi...@apache.org> on 2026/04/20 23:08:40 UTC
[PR] fix(s3): add missing if-none-match request field [opendal]
dentiny opened a new pull request, #7420:
URL: https://github.com/apache/opendal/pull/7420
# Which issue does this PR close?
Closes https://github.com/apache/opendal/issues/7419
# Rationale for this change
All request field in the S3 request should be supported.
# What changes are included in this PR?
This PR adds missing if-none-match field in S3 requests.
# Are there any user-facing changes?
No.
# AI Usage Statement
Cursor helped me auto-complete code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(s3): add missing if-none-match request field [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #7420:
URL: https://github.com/apache/opendal/pull/7420#discussion_r3118639147
##########
core/services/s3/src/core.rs:
##########
@@ -318,6 +318,10 @@ impl S3Core {
req = req.header(IF_MATCH, if_match);
}
+ if let Some(if_none_match) = args.if_none_match() {
Review Comment:
This is wrong because AWS S3 doesn't support input except `*`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(s3): add missing if-none-match request field [opendal]
Posted by "dentiny (via GitHub)" <gi...@apache.org>.
dentiny closed pull request #7420: fix(s3): add missing if-none-match request field
URL: https://github.com/apache/opendal/pull/7420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org