You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by twinkle-sachdeva <gi...@git.apache.org> on 2014/07/24 13:07:48 UTC
[GitHub] spark pull request: SPARK-2604: Incorporating memory overhead of e...
GitHub user twinkle-sachdeva opened a pull request:
https://github.com/apache/spark/pull/1571
SPARK-2604: Incorporating memory overhead of executor during the verifcation of cluster resources, before starting the application
While doing the validation for resources of application master and executor resources with cluster resources, corrected the comparison for executor resources, to keep it in sync with allocation handler, where we add and check the memory overhead too.
please see discussion https://issues.apache.org/jira/browse/SPARK-2604, to get more idea
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twinkle-sachdeva/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1571.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1571
----
commit e4653da61e23ec45aff3cd34f3466d3ee2e3f85b
Author: twinkle.sachdeva <tw...@guavus.com>
Date: 2014-07-24T10:11:58Z
SPARK-2604: Incorporating memory overhead of executor during the verifcation of cluster resources, before starting the application
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2604: Incorporating memory overhead of e...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-2604: Incorporating memory overhead of e...
Posted by tgravescs <gi...@git.apache.org>.
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1571#issuecomment-54979349
The memory overhead checks are actually out of date its inconsistent between yarn alpha and yarn stable as to how it works. https://github.com/apache/spark/pull/2253 is fixing that. I've asked them to fix the checks there also.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-2604: Incorporating memory overhead of e...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1571#issuecomment-49994955
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: SPARK-2604: Incorporating memory overhead of e...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1571#issuecomment-54694561
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-2604: Incorporating memory overhead of e...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/1571#issuecomment-55348511
@twinkle-sachdeva Yes it's a good idea to separate these two overheads. Part of the changes in this PR are now out-dated as of #2253, and the rest of it is incorporated in #2350. Would you mind closing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org