You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2019/11/12 11:29:00 UTC

[jira] [Created] (FLINK-14723) Improve some code about computed column in planner

Jark Wu created FLINK-14723:
-------------------------------

             Summary: Improve some code about computed column in planner
                 Key: FLINK-14723
                 URL: https://issues.apache.org/jira/browse/FLINK-14723
             Project: Flink
          Issue Type: Sub-task
          Components: Table SQL / Planner
            Reporter: Jark Wu
            Assignee: Jark Wu


The following code can be improved which is introduced by FLINK-14665.

1. FlinkRelOptUtilTest#testToString shouldn't ignore attributes of RelNodes. The original expcted string makes sense. We should fix it to keep the result unchanged. 
2. The test {{CatalogTableITCase#testInsertSinkTableWithUnmatchedFields}} should fail and shouldn't verify the expected results (no results).
3. {{SqlToOperationConverterTest#testCreateTableWithComputedColumn}} change the udf calling to non-qualified way to verify the qualifying works well. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)