[GitHub] [airflow] o-nikolas commented on a change in pull request #16050: Update Boto3 API calls in ECSOperator

[GitBox <gi...@apache.org>]

o-nikolas commented on a change in pull request #16050:
URL: https://github.com/apache/airflow/pull/16050#discussion_r653920886



##########
File path: airflow/providers/amazon/aws/operators/ecs.py
##########
@@ -266,11 +266,11 @@ def _start_task(self):
         self.arn = response['tasks'][0]['taskArn']
 
     def _try_reattach_task(self):
-        task_def_resp = self.client.describe_task_definition(self.task_definition)
+        task_def_resp = self.client.describe_task_definition(taskDefinition=self.task_definition)
         ecs_task_family = task_def_resp['taskDefinition']['family']
 
         list_tasks_resp = self.client.list_tasks(
-            cluster=self.cluster, launchType=self.launch_type, desiredStatus='RUNNING', family=ecs_task_family
+            cluster=self.cluster, desiredStatus='RUNNING', family=ecs_task_family

Review comment:
       How did you decide which of the two arguments to drop? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org