You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/12 23:31:11 UTC

[GitHub] leventov opened a new issue #7061: Fix concurrency in old Druid classes

leventov opened a new issue #7061: Fix concurrency in old Druid classes
URL: https://github.com/apache/incubator-druid/issues/7061
 
 
   This issue is a description of this project: https://github.com/apache/incubator-druid/projects/4.
   
   It's suggested to take old Druid classes with concurrency (containing `synchronized`, `volatile`, Executors, ConcurrentHashMaps, etc.) one by one and review them using [this checklist](https://medium.com/@leventov/code-review-checklist-java-concurrency-49398c326154). This way many concurrency bugs can be found. Absolutely all old Druid classes with concurrency can be improved, because none of them has sufficient concurrent control flow, data flow, and threading model documentation, and doesn't justify the use of concurrency (see section 2 in the checklist).
   
   #7038 is an example of such PR that I did myself.
   
   If somebody wants to pick up a particular class to review and improve, please create a PR (or an issue first, if you want to ensure that nobody else works on the same class) and ping me (@leventov) in the PR or the issue description. I'll add it to the project. I also commit to review the PRs that belong to this project.
   
   When picking a class to review and improve one can check the [project dashboard](https://github.com/apache/incubator-druid/projects/4) to see if some class hasn't been already reviewed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org