You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/06/02 03:32:44 UTC

[GitHub] [helix] jiajunwang opened a new pull request #1779: Gracefully handle interruptions in the Helix logic.

jiajunwang opened a new pull request #1779:
URL: https://github.com/apache/helix/pull/1779


   ### Issues
   
   - [X] My PR addresses the following Helix issues and references them in the PR description:
   
   Fixes #1763 
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   This PR aims to address the problem that the interrupt signal is swallowed by the catch logic so the thread is not really interrupted. This may cause leakage or race conditions.
   
   ### Tests
   
   - [X] The following tests are written for this issue:
   
   New test TestAsyncBaseStage has been added to verify that AbstractAsyncBaseStage in the async thread can be canceled correctly.
   The other changes are already covered by the existing tests to prove that they won't fail the normal logic.
   
   - The following is the result of the "mvn test" command on the appropriate module:
   
   (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
   
   ### Changes that Break Backward Compatibility (Optional)
   
   - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
   
   (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang commented on pull request #1779: Gracefully handle interruptions in the Helix logic.

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1779:
URL: https://github.com/apache/helix/pull/1779#issuecomment-853391620






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang merged pull request #1779: Gracefully handle interruptions in the Helix logic.

Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1779:
URL: https://github.com/apache/helix/pull/1779


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang commented on pull request #1779: Gracefully handle interruptions in the Helix logic.

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1779:
URL: https://github.com/apache/helix/pull/1779#issuecomment-853391620


   > lgtm, but seems your build failed?
   
   Tried again and it works. I didn't find any clue like Exceptions. Moreover, I run this test in my localhost for 50 times, very stable. I think we can check-in the PR for now since we agree the change makes sense.
   I will follow up if this test becomes unstable after merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang merged pull request #1779: Gracefully handle interruptions in the Helix logic.

Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1779:
URL: https://github.com/apache/helix/pull/1779


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] jiajunwang commented on pull request #1779: Gracefully handle interruptions in the Helix logic.

Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1779:
URL: https://github.com/apache/helix/pull/1779#issuecomment-853413532


   Approved by @junkaixue , I will merge after https://github.com/apache/helix/pull/1778 since they are related.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org