You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/05/02 03:41:08 UTC
Review Request: Updated the ProcessIsolator to use the new process utilities
to compute resource usage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10899/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See above.
This addresses bug MESOS-370.
https://issues.apache.org/jira/browse/MESOS-370
Diffs
-----
src/slave/process_isolator.cpp 6938fbcca9d384bb014ff4dd52a13763c1f8397a
src/tests/environment.cpp c94c85fc2f710dc2157f6b61edb7bfb0df21a579
src/tests/isolator_tests.cpp 435c780f05b5bc78d1dc4e9cbcbac74971607dc9
Diff: https://reviews.apache.org/r/10899/diff/
Testing
-------
make check on OSX and Linux.
Thanks,
Ben Mahler
Re: Review Request: Updated the ProcessIsolator to use the new process
utilities to compute resource usage.
Posted by Ben Mahler <be...@gmail.com>.
> On May 8, 2013, 6:24 p.m., Benjamin Hindman wrote:
> >
Will be discarded and sending out a separate chain for this due to the restructuring.
> On May 8, 2013, 6:24 p.m., Benjamin Hindman wrote:
> > src/slave/process_isolator.cpp, line 377
> > <https://reviews.apache.org/r/10899/diff/1/?file=286977#file286977line377>
> >
> > What about calling this function 'os::process' and leave proc::status as it's own thing?
> On May 8, 2013, 6:24 p.m., Benjamin Hindman wrote:
> > src/slave/process_isolator.cpp, line 377
> > <https://reviews.apache.org/r/10899/diff/1/?file=286977#file286977line377>
> >
> > What about s/os::status/os::process/ and keeping proc::status as it is?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10899/#review20333
-----------------------------------------------------------
On May 2, 2013, 1:41 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10899/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 1:41 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> This addresses bug MESOS-370.
> https://issues.apache.org/jira/browse/MESOS-370
>
>
> Diffs
> -----
>
> src/slave/process_isolator.cpp 6938fbcca9d384bb014ff4dd52a13763c1f8397a
> src/tests/environment.cpp c94c85fc2f710dc2157f6b61edb7bfb0df21a579
> src/tests/isolator_tests.cpp 435c780f05b5bc78d1dc4e9cbcbac74971607dc9
>
> Diff: https://reviews.apache.org/r/10899/diff/
>
>
> Testing
> -------
>
> make check on OSX and Linux.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Updated the ProcessIsolator to use the new process
utilities to compute resource usage.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10899/#review20333
-----------------------------------------------------------
src/slave/process_isolator.cpp
<https://reviews.apache.org/r/10899/#comment41885>
What about calling this function 'os::process' and leave proc::status as it's own thing?
src/slave/process_isolator.cpp
<https://reviews.apache.org/r/10899/#comment41893>
What about s/os::status/os::process/ and keeping proc::status as it is?
- Benjamin Hindman
On May 2, 2013, 1:41 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10899/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 1:41 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above.
>
>
> This addresses bug MESOS-370.
> https://issues.apache.org/jira/browse/MESOS-370
>
>
> Diffs
> -----
>
> src/slave/process_isolator.cpp 6938fbcca9d384bb014ff4dd52a13763c1f8397a
> src/tests/environment.cpp c94c85fc2f710dc2157f6b61edb7bfb0df21a579
> src/tests/isolator_tests.cpp 435c780f05b5bc78d1dc4e9cbcbac74971607dc9
>
> Diff: https://reviews.apache.org/r/10899/diff/
>
>
> Testing
> -------
>
> make check on OSX and Linux.
>
>
> Thanks,
>
> Ben Mahler
>
>