You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Ivan <xh...@gmail.com> on 2010/06/10 05:42:30 UTC

Re: svn commit: r953208 - in /geronimo/server/branches/2.2: framework/configs/ framework/configs/client-system/ plugins/ plugins/client/ plugins/client/client-security/ plugins/client/client/ plugins/connector/client-transaction/ plugins/corba/client

I am not sure whether we really need to keep the old plugins work in the new
Geronimo release. Do we have corresponding samples for the new release ?
e.g. between different releases, there maybe GBean signatures changes, so
the serialized data will not work correctly.

2010/6/10 <xi...@apache.org>

> Author: xiaming
> Date: Thu Jun 10 03:22:19 2010
> New Revision: 953208
>
> URL: http://svn.apache.org/viewvc?rev=953208&view=rev
> Log:
> GERONIMO-5373 Make 2.2 samples plugins work on G 2.2.1, though only part of
> samples plugins works after this change.
>
> Modified:
>    geronimo/server/branches/2.2/framework/configs/client-system/pom.xml
>    geronimo/server/branches/2.2/framework/configs/pom.xml
>    geronimo/server/branches/2.2/plugins/client/client-security/pom.xml
>    geronimo/server/branches/2.2/plugins/client/client/pom.xml
>    geronimo/server/branches/2.2/plugins/client/pom.xml
>
>  geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml
>    geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml
>    geronimo/server/branches/2.2/plugins/pom.xml
>
> Modified:
> geronimo/server/branches/2.2/framework/configs/client-system/pom.xml
> URL:
> http://svn.apache.org/viewvc/geronimo/server/branches/2.2/framework/configs/client-system/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>
> ==============================================================================
> --- geronimo/server/branches/2.2/framework/configs/client-system/pom.xml
> (original)
> +++ geronimo/server/branches/2.2/framework/configs/client-system/pom.xml
> Thu Jun 10 03:22:19 2010
> @@ -207,6 +207,7 @@
>                             <config-xml-content load="false" />
>                             <artifact-alias server="client"
> key="org.apache.geronimo.framework/j2ee-system//car">org.apache.geronimo.framework/client-system/${version}/car</artifact-alias>
>                             <artifact-alias server="client"
> key="org.apache.geronimo.framework/j2ee-system/${version}/car">org.apache.geronimo.framework/client-system/${version}/car</artifact-alias>
> +                            <artifact-alias server="client"
> key="org.apache.geronimo.framework/j2ee-system/2.2/car">org.apache.geronimo.framework/client-system/${version}/car</artifact-alias>
>                         </plugin-artifact>
>                     </instance>
>
>
> Modified: geronimo/server/branches/2.2/framework/configs/pom.xml
> URL:
> http://svn.apache.org/viewvc/geronimo/server/branches/2.2/framework/configs/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>
> ==============================================================================
> --- geronimo/server/branches/2.2/framework/configs/pom.xml (original)
> +++ geronimo/server/branches/2.2/framework/configs/pom.xml Thu Jun 10
> 03:22:19 2010
> @@ -85,6 +85,7 @@
>
> <source-repository>${PluginSrcRepoCentral}</source-repository>
>
> <source-repository>${PluginSrcRepoApacheSnapshots}</source-repository>
>                             <artifact-alias
> key="${groupId}/${artifactId}//car">${groupId}/${artifactId}/${version}/car</artifact-alias>
> +                            <artifact-alias
> key="${groupId}/${artifactId}/2.2/car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>                         </plugin-artifact>
>                     </commonInstance>
>                 </configuration>
>
> Modified:
> geronimo/server/branches/2.2/plugins/client/client-security/pom.xml
> URL:
> http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/client/client-security/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>
> ==============================================================================
> --- geronimo/server/branches/2.2/plugins/client/client-security/pom.xml
> (original)
> +++ geronimo/server/branches/2.2/plugins/client/client-security/pom.xml Thu
> Jun 10 03:22:19 2010
> @@ -78,6 +78,7 @@
>                             <config-xml-content load="false" />
>                             <artifact-alias server="client"
> key="org.apache.geronimo.framework/j2ee-security//car">org.apache.geronimo.configs/client-security/${version}/car</artifact-alias>
>                             <artifact-alias server="client"
> key="org.apache.geronimo.framework/j2ee-security/${version}/car">org.apache.geronimo.configs/client-security/${version}/car</artifact-alias>
> +                            <artifact-alias server="client"
> key="org.apache.geronimo.framework/j2ee-security/2.2/car">org.apache.geronimo.configs/client-security/${version}/car</artifact-alias>
>                         </plugin-artifact>
>                     </instance>
>                 </configuration>
>
> Modified: geronimo/server/branches/2.2/plugins/client/client/pom.xml
> URL:
> http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/client/client/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>
> ==============================================================================
> --- geronimo/server/branches/2.2/plugins/client/client/pom.xml (original)
> +++ geronimo/server/branches/2.2/plugins/client/client/pom.xml Thu Jun 10
> 03:22:19 2010
> @@ -153,6 +153,7 @@
>                             <config-xml-content load="false" />
>                             <artifact-alias server="client"
> key="org.apache.geronimo.configs/j2ee-server//car">org.apache.geronimo.configs/client/${version}/car</artifact-alias>
>                             <artifact-alias server="client"
> key="org.apache.geronimo.configs/j2ee-server/${version}/car">org.apache.geronimo.configs/client/${version}/car</artifact-alias>
> +                            <artifact-alias server="client"
> key="org.apache.geronimo.configs/j2ee-server/2.2/car">org.apache.geronimo.configs/client/${version}/car</artifact-alias>
>                         </plugin-artifact>
>                     </instance>
>                 </configuration>
>
> Modified: geronimo/server/branches/2.2/plugins/client/pom.xml
> URL:
> http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/client/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>
> ==============================================================================
> --- geronimo/server/branches/2.2/plugins/client/pom.xml (original)
> +++ geronimo/server/branches/2.2/plugins/client/pom.xml Thu Jun 10 03:22:19
> 2010
> @@ -60,6 +60,7 @@
>
> <source-repository>${PluginSrcRepoApacheSnapshots}</source-repository>
>
>                             <artifact-alias server="client"
> key="${groupId}/${artifactId}//car">${groupId}/${artifactId}/${version}/car</artifact-alias>
> +                            <artifact-alias server="client"
> key="${groupId}/${artifactId}/2.2/car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>                         </plugin-artifact>
>                     </commonInstance>
>                 </configuration>
>
> Modified:
> geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml
> URL:
> http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>
> ==============================================================================
> ---
> geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml
> (original)
> +++
> geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml
> Thu Jun 10 03:22:19 2010
> @@ -105,6 +105,7 @@
>                             <config-xml-content load="false" />
>                             <artifact-alias server="client"
> key="org.apache.geronimo.configs/transaction//car">org.apache.geronimo.configs/client-transaction/${version}/car</artifact-alias>
>                             <artifact-alias server="client"
> key="org.apache.geronimo.configs/transaction/${version}/car">org.apache.geronimo.configs/client-transaction/${version}/car</artifact-alias>
> +                            <artifact-alias server="client"
> key="org.apache.geronimo.configs/transaction/2.2/car">org.apache.geronimo.configs/client-transaction/${version}/car</artifact-alias>
>                         </plugin-artifact>
>                     </instance>
>                 </configuration>
>
> Modified:
> geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml
> URL:
> http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>
> ==============================================================================
> --- geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml
> (original)
> +++ geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml
> Thu Jun 10 03:22:19 2010
> @@ -178,6 +178,7 @@
>                         <plugin-artifact>
>                             <config-xml-content load="false" />
>                             <artifact-alias server="client"
> key="${groupId}/${artifactId}//car">${groupId}/${artifactId}/${version}/car</artifact-alias>
> +                            <artifact-alias server="client"
> key="${groupId}/${artifactId}/2.2/car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>                         </plugin-artifact>
>                     </instance>
>                 </configuration>
>
> Modified: geronimo/server/branches/2.2/plugins/pom.xml
> URL:
> http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>
> ==============================================================================
> --- geronimo/server/branches/2.2/plugins/pom.xml (original)
> +++ geronimo/server/branches/2.2/plugins/pom.xml Thu Jun 10 03:22:19 2010
> @@ -125,6 +125,7 @@
>
> <source-repository>${PluginSrcRepoCentral}</source-repository>
>
> <source-repository>${PluginSrcRepoApacheSnapshots}</source-repository>
>                             <artifact-alias
> key="${groupId}/${artifactId}//car">${groupId}/${artifactId}/${version}/car</artifact-alias>
> +                            <artifact-alias
> key="${groupId}/${artifactId}/2.2/car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>                         </plugin-artifact>
>                     </commonInstance>
>                 </configuration>
>
>
>


-- 
Ivan

Re: svn commit: r953208 - in /geronimo/server/branches/2.2: framework/configs/ framework/configs/client-system/ plugins/ plugins/client/ plugins/client/client-security/ plugins/client/client/ plugins/connector/client-transaction/ plugins/corba/client

Posted by Donald Woods <dw...@apache.org>.
It can go either way.  Most of the time, we expect plugin providers to
update their CAR builds to add in the new server releases (see
geronimo/plugins/openjpa2/).  Ideally, the Samples would be released
with every server release, but we have never done that in the past, but
it is something we need to start doing.

If you add artifact-alias entries so the server can support older
Samples, then I'm afraid this will become a maintenance problem, as you
may also need to add in mappings to handle upgraded levels of Jetty,
Tomcat, OpenEJB, OpenJPA, ....  Then the question becomes, how many
intra-release levels do you support?  Only 2.2 plugins working on 2.2.1
or any 2.2.x plugins working on all future levels of 2.2.x forever.  I'm
really against this scenario, as it greatly complicates creating new
maintenance releases, as you have to go in and find/add new alias
entries after every release.


-Donald


On 6/9/10 11:42 PM, Ivan wrote:
> I am not sure whether we really need to keep the old plugins work in the
> new Geronimo release. Do we have corresponding samples for the new release ?
> e.g. between different releases, there maybe GBean signatures changes,
> so the serialized data will not work correctly.
> 
> 2010/6/10 <xiaming@apache.org <ma...@apache.org>>
> 
>     Author: xiaming
>     Date: Thu Jun 10 03:22:19 2010
>     New Revision: 953208
> 
>     URL: http://svn.apache.org/viewvc?rev=953208&view=rev
>     <http://svn.apache.org/viewvc?rev=953208&view=rev>
>     Log:
>     GERONIMO-5373 Make 2.2 samples plugins work on G 2.2.1, though only
>     part of samples plugins works after this change.
> 
>     Modified:
>        geronimo/server/branches/2.2/framework/configs/client-system/pom.xml
>        geronimo/server/branches/2.2/framework/configs/pom.xml
>        geronimo/server/branches/2.2/plugins/client/client-security/pom.xml
>        geronimo/server/branches/2.2/plugins/client/client/pom.xml
>        geronimo/server/branches/2.2/plugins/client/pom.xml
>      
>      geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml
>        geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml
>        geronimo/server/branches/2.2/plugins/pom.xml
> 
>     Modified:
>     geronimo/server/branches/2.2/framework/configs/client-system/pom.xml
>     URL:
>     http://svn.apache.org/viewvc/geronimo/server/branches/2.2/framework/configs/client-system/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>     <http://svn.apache.org/viewvc/geronimo/server/branches/2.2/framework/configs/client-system/pom.xml?rev=953208&r1=953207&r2=953208&view=diff>
>     ==============================================================================
>     ---
>     geronimo/server/branches/2.2/framework/configs/client-system/pom.xml
>     (original)
>     +++
>     geronimo/server/branches/2.2/framework/configs/client-system/pom.xml
>     Thu Jun 10 03:22:19 2010
>     @@ -207,6 +207,7 @@
>                                 <config-xml-content load="false" />
>                                 <artifact-alias server="client"
>     key="org.apache.geronimo.framework/j2ee-system//car">org.apache.geronimo.framework/client-system/${version}/car</artifact-alias>
>                                 <artifact-alias server="client"
>     key="org.apache.geronimo.framework/j2ee-system/${version}/car">org.apache.geronimo.framework/client-system/${version}/car</artifact-alias>
>     +                            <artifact-alias server="client"
>     key="org.apache.geronimo.framework/j2ee-system/2.2/car">org.apache.geronimo.framework/client-system/${version}/car</artifact-alias>
>                             </plugin-artifact>
>                         </instance>
> 
> 
>     Modified: geronimo/server/branches/2.2/framework/configs/pom.xml
>     URL:
>     http://svn.apache.org/viewvc/geronimo/server/branches/2.2/framework/configs/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>     <http://svn.apache.org/viewvc/geronimo/server/branches/2.2/framework/configs/pom.xml?rev=953208&r1=953207&r2=953208&view=diff>
>     ==============================================================================
>     --- geronimo/server/branches/2.2/framework/configs/pom.xml (original)
>     +++ geronimo/server/branches/2.2/framework/configs/pom.xml Thu Jun
>     10 03:22:19 2010
>     @@ -85,6 +85,7 @@
>                                
>     <source-repository>${PluginSrcRepoCentral}</source-repository>
>                                
>     <source-repository>${PluginSrcRepoApacheSnapshots}</source-repository>
>                                 <artifact-alias
>     key="${groupId}/${artifactId}//car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>     +                            <artifact-alias
>     key="${groupId}/${artifactId}/2.2/car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>                             </plugin-artifact>
>                         </commonInstance>
>                     </configuration>
> 
>     Modified:
>     geronimo/server/branches/2.2/plugins/client/client-security/pom.xml
>     URL:
>     http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/client/client-security/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>     <http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/client/client-security/pom.xml?rev=953208&r1=953207&r2=953208&view=diff>
>     ==============================================================================
>     ---
>     geronimo/server/branches/2.2/plugins/client/client-security/pom.xml
>     (original)
>     +++
>     geronimo/server/branches/2.2/plugins/client/client-security/pom.xml
>     Thu Jun 10 03:22:19 2010
>     @@ -78,6 +78,7 @@
>                                 <config-xml-content load="false" />
>                                 <artifact-alias server="client"
>     key="org.apache.geronimo.framework/j2ee-security//car">org.apache.geronimo.configs/client-security/${version}/car</artifact-alias>
>                                 <artifact-alias server="client"
>     key="org.apache.geronimo.framework/j2ee-security/${version}/car">org.apache.geronimo.configs/client-security/${version}/car</artifact-alias>
>     +                            <artifact-alias server="client"
>     key="org.apache.geronimo.framework/j2ee-security/2.2/car">org.apache.geronimo.configs/client-security/${version}/car</artifact-alias>
>                             </plugin-artifact>
>                         </instance>
>                     </configuration>
> 
>     Modified: geronimo/server/branches/2.2/plugins/client/client/pom.xml
>     URL:
>     http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/client/client/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>     <http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/client/client/pom.xml?rev=953208&r1=953207&r2=953208&view=diff>
>     ==============================================================================
>     --- geronimo/server/branches/2.2/plugins/client/client/pom.xml
>     (original)
>     +++ geronimo/server/branches/2.2/plugins/client/client/pom.xml Thu
>     Jun 10 03:22:19 2010
>     @@ -153,6 +153,7 @@
>                                 <config-xml-content load="false" />
>                                 <artifact-alias server="client"
>     key="org.apache.geronimo.configs/j2ee-server//car">org.apache.geronimo.configs/client/${version}/car</artifact-alias>
>                                 <artifact-alias server="client"
>     key="org.apache.geronimo.configs/j2ee-server/${version}/car">org.apache.geronimo.configs/client/${version}/car</artifact-alias>
>     +                            <artifact-alias server="client"
>     key="org.apache.geronimo.configs/j2ee-server/2.2/car">org.apache.geronimo.configs/client/${version}/car</artifact-alias>
>                             </plugin-artifact>
>                         </instance>
>                     </configuration>
> 
>     Modified: geronimo/server/branches/2.2/plugins/client/pom.xml
>     URL:
>     http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/client/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>     <http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/client/pom.xml?rev=953208&r1=953207&r2=953208&view=diff>
>     ==============================================================================
>     --- geronimo/server/branches/2.2/plugins/client/pom.xml (original)
>     +++ geronimo/server/branches/2.2/plugins/client/pom.xml Thu Jun 10
>     03:22:19 2010
>     @@ -60,6 +60,7 @@
>                                
>     <source-repository>${PluginSrcRepoApacheSnapshots}</source-repository>
> 
>                                 <artifact-alias server="client"
>     key="${groupId}/${artifactId}//car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>     +                            <artifact-alias server="client"
>     key="${groupId}/${artifactId}/2.2/car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>                             </plugin-artifact>
>                         </commonInstance>
>                     </configuration>
> 
>     Modified:
>     geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml
>     URL:
>     http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>     <http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml?rev=953208&r1=953207&r2=953208&view=diff>
>     ==============================================================================
>     ---
>     geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml
>     (original)
>     +++
>     geronimo/server/branches/2.2/plugins/connector/client-transaction/pom.xml
>     Thu Jun 10 03:22:19 2010
>     @@ -105,6 +105,7 @@
>                                 <config-xml-content load="false" />
>                                 <artifact-alias server="client"
>     key="org.apache.geronimo.configs/transaction//car">org.apache.geronimo.configs/client-transaction/${version}/car</artifact-alias>
>                                 <artifact-alias server="client"
>     key="org.apache.geronimo.configs/transaction/${version}/car">org.apache.geronimo.configs/client-transaction/${version}/car</artifact-alias>
>     +                            <artifact-alias server="client"
>     key="org.apache.geronimo.configs/transaction/2.2/car">org.apache.geronimo.configs/client-transaction/${version}/car</artifact-alias>
>                             </plugin-artifact>
>                         </instance>
>                     </configuration>
> 
>     Modified:
>     geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml
>     URL:
>     http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>     <http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml?rev=953208&r1=953207&r2=953208&view=diff>
>     ==============================================================================
>     ---
>     geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml
>     (original)
>     +++
>     geronimo/server/branches/2.2/plugins/corba/client-corba-yoko/pom.xml
>     Thu Jun 10 03:22:19 2010
>     @@ -178,6 +178,7 @@
>                             <plugin-artifact>
>                                 <config-xml-content load="false" />
>                                 <artifact-alias server="client"
>     key="${groupId}/${artifactId}//car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>     +                            <artifact-alias server="client"
>     key="${groupId}/${artifactId}/2.2/car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>                             </plugin-artifact>
>                         </instance>
>                     </configuration>
> 
>     Modified: geronimo/server/branches/2.2/plugins/pom.xml
>     URL:
>     http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/pom.xml?rev=953208&r1=953207&r2=953208&view=diff
>     <http://svn.apache.org/viewvc/geronimo/server/branches/2.2/plugins/pom.xml?rev=953208&r1=953207&r2=953208&view=diff>
>     ==============================================================================
>     --- geronimo/server/branches/2.2/plugins/pom.xml (original)
>     +++ geronimo/server/branches/2.2/plugins/pom.xml Thu Jun 10 03:22:19
>     2010
>     @@ -125,6 +125,7 @@
>                                
>     <source-repository>${PluginSrcRepoCentral}</source-repository>
>                                
>     <source-repository>${PluginSrcRepoApacheSnapshots}</source-repository>
>                                 <artifact-alias
>     key="${groupId}/${artifactId}//car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>     +                            <artifact-alias
>     key="${groupId}/${artifactId}/2.2/car">${groupId}/${artifactId}/${version}/car</artifact-alias>
>                             </plugin-artifact>
>                         </commonInstance>
>                     </configuration>
> 
> 
> 
> 
> 
> -- 
> Ivan

Re: svn commit: r953208 - in /geronimo/server/branches/2.2: framework/configs/ framework/configs/client-system/ plugins/ plugins/client/ plugins/client/client-security/ plugins/client/client/ plugins/connector/client-transaction/ plugins/corba/client

Posted by Forrest Xia <fo...@gmail.com>.
Since there is no samples update, we don't plan to do a samples release for
G 2.2.1. As you pointed out, not every G 2.2 samples plugins work for G
2.2.1.

Forrest