You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openjpa.apache.org by pp...@apache.org on 2012/07/03 04:18:04 UTC
svn commit: r1356544 -
/openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java
Author: ppoddar
Date: Tue Jul 3 02:18:03 2012
New Revision: 1356544
URL: http://svn.apache.org/viewvc?rev=1356544&view=rev
Log:
Reduce log level when meta class not found
Modified:
openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java
Modified: openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java?rev=1356544&r1=1356543&r2=1356544&view=diff
==============================================================================
--- openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java (original)
+++ openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java Tue Jul 3 02:18:03 2012
@@ -1865,7 +1865,7 @@ public class MetaDataRepository implemen
_metamodel.put(entity, m2cls);
return m2cls;
} catch (Throwable t) {
- if (_log.isInfoEnabled())
+ if (_log.isTraceEnabled())
_log.warn(_loc.get("meta-no-model", m2, entity, t));
}
return null;
Re: svn commit: r1356544 - /openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java
Posted by Kevin Sutter <kw...@gmail.com>.
Pinaki,
This change isn't right. The original code was logging a warning. So, if
you want to change this conditional to isWarnEnabled(), I can understand
that. But, now with your change, we're checking isTraceEnabled() and
logging a Warning. Doesn't make sense. I think changing the conditional
to isWarnEnabled() the proper fix.
thanks,
Kevin
On Mon, Jul 2, 2012 at 9:18 PM, <pp...@apache.org> wrote:
> Author: ppoddar
> Date: Tue Jul 3 02:18:03 2012
> New Revision: 1356544
>
> URL: http://svn.apache.org/viewvc?rev=1356544&view=rev
> Log:
> Reduce log level when meta class not found
>
> Modified:
>
> openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java
>
> Modified:
> openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java
> URL:
> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java?rev=1356544&r1=1356543&r2=1356544&view=diff
>
> ==============================================================================
> ---
> openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java
> (original)
> +++
> openjpa/trunk/openjpa-kernel/src/main/java/org/apache/openjpa/meta/MetaDataRepository.java
> Tue Jul 3 02:18:03 2012
> @@ -1865,7 +1865,7 @@ public class MetaDataRepository implemen
> _metamodel.put(entity, m2cls);
> return m2cls;
> } catch (Throwable t) {
> - if (_log.isInfoEnabled())
> + if (_log.isTraceEnabled())
> _log.warn(_loc.get("meta-no-model", m2, entity, t));
> }
> return null;
>
>
>