You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/14 19:46:33 UTC
[GitHub] [helix] jiajunwang opened a new pull request #1271: Don't skip WAGED rebalancer calculation even the resource list is empty.
jiajunwang opened a new pull request #1271:
URL: https://github.com/apache/helix/pull/1271
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixes #1257
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
This change is to allow the rebalancer logic cleaning up the internal assignment state and cache if all the resources are removed from the cluster.
### Tests
- [X] The following tests are written for this issue:
TestWagedRebalance. testRecreateSameResource
- [ ] The following is the result of the "mvn test" command on the appropriate module:
Running
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on pull request #1271: Don't skip WAGED rebalancer calculation even the resource list is empty.
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on pull request #1271:
URL: https://github.com/apache/helix/pull/1271#issuecomment-674288370
Please update the PR title before merging. :) @jiajunwang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1271: Don't skip WAGED rebalancer calculation even the resource list is empty.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1271:
URL: https://github.com/apache/helix/pull/1271#issuecomment-674313568
The title is the final one which describes the change. For the other information, it has been described in the issue.
This PR has been approved and ready to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1271: Don't skip WAGED rebalancer calculation even the resource list is empty.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1271:
URL: https://github.com/apache/helix/pull/1271#discussion_r470859774
##########
File path: helix-core/src/test/java/org/apache/helix/integration/rebalancer/WagedRebalancer/TestWagedRebalance.java
##########
@@ -653,6 +674,36 @@ public void testRebalancerReset() throws Exception {
Assert.assertFalse(newEV.equals(oldEV));
}
+ @Test(dependsOnMethods = "test")
+ public void testRecreateSameResource() throws InterruptedException {
Review comment:
Without the change, this test will fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #1271: Don't skip WAGED rebalancer calculation even the resource list is empty.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #1271:
URL: https://github.com/apache/helix/pull/1271#discussion_r470859721
##########
File path: helix-core/src/test/java/org/apache/helix/integration/rebalancer/WagedRebalancer/TestWagedRebalance.java
##########
@@ -653,6 +674,36 @@ public void testRebalancerReset() throws Exception {
Assert.assertFalse(newEV.equals(oldEV));
}
+ @Test(dependsOnMethods = "test")
+ public void testRecreateSameResource() throws InterruptedException {
Review comment:
It is the issue that we want to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1271: Don't skip WAGED rebalancer calculation even the resource list is empty.
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1271:
URL: https://github.com/apache/helix/pull/1271
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] NealSun96 commented on a change in pull request #1271: Don't skip WAGED rebalancer calculation even the resource list is empty.
Posted by GitBox <gi...@apache.org>.
NealSun96 commented on a change in pull request #1271:
URL: https://github.com/apache/helix/pull/1271#discussion_r470856250
##########
File path: helix-core/src/test/java/org/apache/helix/integration/rebalancer/WagedRebalancer/TestWagedRebalance.java
##########
@@ -653,6 +674,36 @@ public void testRebalancerReset() throws Exception {
Assert.assertFalse(newEV.equals(oldEV));
}
+ @Test(dependsOnMethods = "test")
+ public void testRecreateSameResource() throws InterruptedException {
Review comment:
This is not related to the code change, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org