You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/12/22 08:40:21 UTC
[GitHub] [hadoop-ozone] vivekratnavel opened a new pull request #386:
HDDS-2504. Handle InterruptedException properly.
vivekratnavel opened a new pull request #386: HDDS-2504. Handle InterruptedException properly.
URL: https://github.com/apache/hadoop-ozone/pull/386
HDDS-2557. Handle InterruptedException in CommitWatcher
HDDS-2558. Handle InterruptedException in XceiverClientSpi
HDDS-2559. Handle InterruptedException in BackgroundService
HDDS-2560. Handle InterruptedException in Scheduler
## What changes were proposed in this pull request?
Sonar lint fixes for CommitWatcher, XceiverClientSpi, BackgroundService and Scheduler
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2557
https://issues.apache.org/jira/browse/HDDS-2558
https://issues.apache.org/jira/browse/HDDS-2559
https://issues.apache.org/jira/browse/HDDS-2560
## How was this patch tested?
Compiles successfully without any errors in local.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on a change in pull request
#386: HDDS-2504. Handle InterruptedException properly.
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on a change in pull request #386: HDDS-2504. Handle InterruptedException properly.
URL: https://github.com/apache/hadoop-ozone/pull/386#discussion_r362410277
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/Scheduler.java
##########
@@ -48,23 +48,24 @@
* @param numCoreThreads - number of core threads to maintain in the scheduler
*/
public Scheduler(String threadName, boolean isDaemon, int numCoreThreads) {
- scheduler = Executors.newScheduledThreadPool(numCoreThreads, r -> {
- Thread t = new Thread(r);
- t.setName(threadName);
- t.setDaemon(isDaemon);
- return t;
- });
+ scheduledExecutorService = Executors.newScheduledThreadPool(numCoreThreads,
+ r -> {
+ Thread t = new Thread(r);
+ t.setName(threadName);
+ t.setDaemon(isDaemon);
+ return t;
+ });
Review comment:
@adoroszlai Fixed it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#386: HDDS-2504. Handle InterruptedException properly.
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #386: HDDS-2504. Handle InterruptedException properly.
URL: https://github.com/apache/hadoop-ozone/pull/386#discussion_r362406210
##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/Scheduler.java
##########
@@ -48,23 +48,24 @@
* @param numCoreThreads - number of core threads to maintain in the scheduler
*/
public Scheduler(String threadName, boolean isDaemon, int numCoreThreads) {
- scheduler = Executors.newScheduledThreadPool(numCoreThreads, r -> {
- Thread t = new Thread(r);
- t.setName(threadName);
- t.setDaemon(isDaemon);
- return t;
- });
+ scheduledExecutorService = Executors.newScheduledThreadPool(numCoreThreads,
+ r -> {
+ Thread t = new Thread(r);
+ t.setName(threadName);
+ t.setDaemon(isDaemon);
+ return t;
+ });
Review comment:
Indent looks odd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on issue #386: HDDS-2504.
Handle InterruptedException properly.
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #386: HDDS-2504. Handle InterruptedException properly.
URL: https://github.com/apache/hadoop-ozone/pull/386#issuecomment-570287912
@adoroszlai Thanks for the review and merge!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #386: HDDS-2504.
Handle InterruptedException properly.
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #386: HDDS-2504. Handle InterruptedException properly.
URL: https://github.com/apache/hadoop-ozone/pull/386
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] vivekratnavel commented on issue #386: HDDS-2504.
Handle InterruptedException properly.
Posted by GitBox <gi...@apache.org>.
vivekratnavel commented on issue #386: HDDS-2504. Handle InterruptedException properly.
URL: https://github.com/apache/hadoop-ozone/pull/386#issuecomment-568245366
@anuengineer @elek @dineshchitlangia @adoroszlai Please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org