[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226671#comment-15226671 ] 

ASF GitHub Bot commented on BROOKLYN-249:
-----------------------------------------

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-server/pull/103

    Fix BROOKLYN-249

    See more detailed descriptions in each commit message.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-server fix/BROOKLYN-249

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit 99dd3ba4fc507988bdecd4e57c2b36cbb465b2a5
Author: Aled Sage <al...@gmail.com>
Date:   2016-04-05T16:58:31Z

    BROOKLYN-249: JcloudsLocation resolves external config
    
    Previously we were just resolving it for identity/credential in 
    getComputeService(). Now we resolve it for everything that obtain()
    does.

commit ee3159bf4e94a1ef9a32c8c5c46a790be2c56146
Author: Aled Sage <al...@gmail.com>
Date:   2016-04-05T16:59:03Z

    Trim publicKeyData
    
    Otherwise get incorrect warning about the publicKey not matching
    the privateKey.

commit b35ec4aabbcc2fe2dc07f1b1cc23a0f92d3d9155
Author: Aled Sage <al...@gmail.com>
Date:   2016-04-05T17:00:21Z

    BROOKLYN-249: fix location rebind for external config
    
    Fixes it only for ConfigKeys, rather than for fields that use
    `@SetFromFlag`. The latter can be addressed in a separate pull request.

commit 6fd90b6c1d097ff18c18bcea321bccb94897efbf
Author: Aled Sage <al...@gmail.com>
Date:   2016-04-05T17:05:43Z

    BROOKLYN-249: test JcloudsLocation external config

----


> errors using external config for JcloudsLocation
> ------------------------------------------------
>
>                 Key: BROOKLYN-249
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-249
>             Project: Brooklyn
>          Issue Type: Bug
>            Reporter: Aled Sage
>
> Using 0.10.0-SNAPSHOT (also affecting 0.9.0-rc2), I hit problems using external config with JcloudsLocation.
> First it failed to resolve the external config for the ssh publicKeyData and privateKeyData.
> After fixing that, it failed to rebind to my persisted state that included the external config in the location (it tried to coerce the {{DeferredSupplier}} to a String).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)