You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/07/16 17:01:41 UTC

[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #819: [KYUUBI #283] Add a sync client to ensure all requests sent to engine with in a session are in order

yaooqinn opened a new pull request #819:
URL: https://github.com/apache/incubator-kyuubi/pull/819


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   Add a sync client to ensure all requests sent to engine with in a session are in order
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #819: [KYUUBI #283] Add a sync client to ensure all requests sent to engine within a session are in order

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #819:
URL: https://github.com/apache/incubator-kyuubi/pull/819


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #819: [KYUUBI #283] Add a sync client to ensure all requests sent to engine within a session are in order

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #819:
URL: https://github.com/apache/incubator-kyuubi/pull/819#issuecomment-882052946


   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #819: [KYUUBI #283] Add a sync client to ensure all requests sent to engine within a session are in order

Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #819:
URL: https://github.com/apache/incubator-kyuubi/pull/819#discussion_r671794640



##########
File path: kyuubi-main/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala
##########
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.kyuubi.client
+
+import java.util.concurrent.locks.ReentrantLock
+
+import scala.collection.JavaConverters._
+
+import org.apache.hive.service.rpc.thrift._
+import org.apache.thrift.protocol.TProtocol
+
+import org.apache.kyuubi.KyuubiSQLException
+import org.apache.kyuubi.operation.FetchOrientation
+import org.apache.kyuubi.operation.FetchOrientation.FetchOrientation
+import org.apache.kyuubi.util.ThriftUtils
+
+class KyuubiSyncThriftClient(protocol: TProtocol) extends TCLIService.Client(protocol) {
+
+  @volatile private var _remoteSessionHandle: TSessionHandle = _
+
+  private val lock = new ReentrantLock()
+
+  /**
+   * Lock every rpc call to send them sequentially
+   */
+  private def withLockAcquired[T](block: => T): T = {
+    try {
+      lock.lock()
+      if (!protocol.getTransport.isOpen) {
+        throw KyuubiSQLException.connectionDoesNotExist()
+      }
+      block
+    } finally lock.unlock()

Review comment:
       seems the explicit `ReentrantLock` can be simplified by `synchronized { }` here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #819: [KYUUBI #283] Add a sync client to ensure all requests sent to engine with in a session are in order

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #819:
URL: https://github.com/apache/incubator-kyuubi/pull/819#issuecomment-881600708


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#819](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c73fd0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/df8da8240e4d6c12af5027542b9c80f2cae1ee0e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df8da82) will **increase** coverage by `0.20%`.
   > The diff coverage is `70.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #819      +/-   ##
   ============================================
   + Coverage     78.70%   78.90%   +0.20%     
     Complexity       10       10              
   ============================================
     Files           132      133       +1     
     Lines          5108     5095      -13     
     Branches        638      638              
   ============================================
     Hits           4020     4020              
   + Misses          740      726      -14     
   - Partials        348      349       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/scala/org/apache/kyuubi/KyuubiSQLException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9LeXV1YmlTUUxFeGNlcHRpb24uc2NhbGE=) | `86.36% <0.00%> (-1.00%)` | :arrow_down: |
   | [...scala/org/apache/kyuubi/operation/GetColumns.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldENvbHVtbnMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ala/org/apache/kyuubi/operation/GetFunctions.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldEZ1bmN0aW9ucy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...la/org/apache/kyuubi/operation/GetTableTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldFRhYmxlVHlwZXMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0t5dXViaU9wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `60.00% <60.00%> (+5.33%)` | :arrow_up: |
   | [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0t5dXViaU9wZXJhdGlvbi5zY2FsYQ==) | `52.72% <66.66%> (-4.85%)` | :arrow_down: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L0t5dXViaVN5bmNUaHJpZnRDbGllbnQuc2NhbGE=) | `73.03% <73.03%> (ø)` | |
   | [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvc2Vzc2lvbi9LeXV1YmlTZXNzaW9uSW1wbC5zY2FsYQ==) | `88.23% <83.33%> (-5.39%)` | :arrow_down: |
   | [...apache/kyuubi/service/AbstractBackendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Fic3RyYWN0QmFja2VuZFNlcnZpY2Uuc2NhbGE=) | `83.72% <100.00%> (-0.37%)` | :arrow_down: |
   | [...la/org/apache/kyuubi/service/FrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Zyb250ZW5kU2VydmljZS5zY2FsYQ==) | `97.00% <100.00%> (-0.02%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df8da82...5c73fd0](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #819: [KYUUBI #283] Add a sync client to ensure all requests sent to engine with in a session are in order

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #819:
URL: https://github.com/apache/incubator-kyuubi/pull/819#issuecomment-881600708


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#819](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8bb2c81) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/df8da8240e4d6c12af5027542b9c80f2cae1ee0e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df8da82) will **increase** coverage by `0.21%`.
   > The diff coverage is `70.07%`.
   
   > :exclamation: Current head 8bb2c81 differs from pull request most recent head 16cb863. Consider uploading reports for the commit 16cb863 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #819      +/-   ##
   ============================================
   + Coverage     78.70%   78.91%   +0.21%     
     Complexity       10       10              
   ============================================
     Files           132      133       +1     
     Lines          5108     5084      -24     
     Branches        638      638              
   ============================================
   - Hits           4020     4012       -8     
   + Misses          740      722      -18     
   - Partials        348      350       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/scala/org/apache/kyuubi/KyuubiSQLException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9LeXV1YmlTUUxFeGNlcHRpb24uc2NhbGE=) | `86.36% <0.00%> (-1.00%)` | :arrow_down: |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `95.50% <ø> (+2.95%)` | :arrow_up: |
   | [...scala/org/apache/kyuubi/operation/GetColumns.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldENvbHVtbnMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ala/org/apache/kyuubi/operation/GetFunctions.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldEZ1bmN0aW9ucy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...la/org/apache/kyuubi/operation/GetTableTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldFRhYmxlVHlwZXMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0t5dXViaU9wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `60.00% <60.00%> (+5.33%)` | :arrow_up: |
   | [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0t5dXViaU9wZXJhdGlvbi5zY2FsYQ==) | `52.72% <66.66%> (-4.85%)` | :arrow_down: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L0t5dXViaVN5bmNUaHJpZnRDbGllbnQuc2NhbGE=) | `72.72% <72.72%> (ø)` | |
   | [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvc2Vzc2lvbi9LeXV1YmlTZXNzaW9uSW1wbC5zY2FsYQ==) | `87.87% <83.33%> (-5.74%)` | :arrow_down: |
   | [...apache/kyuubi/service/AbstractBackendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Fic3RyYWN0QmFja2VuZFNlcnZpY2Uuc2NhbGE=) | `83.72% <100.00%> (-0.37%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df8da82...16cb863](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #819: [KYUUBI #283] Add a sync client to ensure all requests sent to engine with in a session are in order

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #819:
URL: https://github.com/apache/incubator-kyuubi/pull/819#issuecomment-881600708


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#819](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (16cb863) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/df8da8240e4d6c12af5027542b9c80f2cae1ee0e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df8da82) will **increase** coverage by `0.15%`.
   > The diff coverage is `70.07%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #819      +/-   ##
   ============================================
   + Coverage     78.70%   78.85%   +0.15%     
     Complexity       10       10              
   ============================================
     Files           132      133       +1     
     Lines          5108     5088      -20     
     Branches        638      639       +1     
   ============================================
   - Hits           4020     4012       -8     
   + Misses          740      725      -15     
   - Partials        348      351       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/scala/org/apache/kyuubi/KyuubiSQLException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9LeXV1YmlTUUxFeGNlcHRpb24uc2NhbGE=) | `86.36% <0.00%> (-1.00%)` | :arrow_down: |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `95.50% <ø> (+2.95%)` | :arrow_up: |
   | [...scala/org/apache/kyuubi/operation/GetColumns.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldENvbHVtbnMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ala/org/apache/kyuubi/operation/GetFunctions.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldEZ1bmN0aW9ucy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...la/org/apache/kyuubi/operation/GetTableTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldFRhYmxlVHlwZXMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0t5dXViaU9wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `60.00% <60.00%> (+5.33%)` | :arrow_up: |
   | [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0t5dXViaU9wZXJhdGlvbi5zY2FsYQ==) | `52.72% <66.66%> (-4.85%)` | :arrow_down: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L0t5dXViaVN5bmNUaHJpZnRDbGllbnQuc2NhbGE=) | `72.72% <72.72%> (ø)` | |
   | [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvc2Vzc2lvbi9LeXV1YmlTZXNzaW9uSW1wbC5zY2FsYQ==) | `87.87% <83.33%> (-5.74%)` | :arrow_down: |
   | [...apache/kyuubi/service/AbstractBackendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Fic3RyYWN0QmFja2VuZFNlcnZpY2Uuc2NhbGE=) | `83.72% <100.00%> (-0.37%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df8da82...16cb863](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #819: [KYUUBI #283] Add a sync client to ensure all requests sent to engine with in a session are in order

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #819:
URL: https://github.com/apache/incubator-kyuubi/pull/819#issuecomment-881600708


   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#819](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8bb2c81) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/df8da8240e4d6c12af5027542b9c80f2cae1ee0e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df8da82) will **increase** coverage by `0.21%`.
   > The diff coverage is `70.07%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/graphs/tree.svg?width=650&height=150&src=pr&token=925D4tb9AH&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #819      +/-   ##
   ============================================
   + Coverage     78.70%   78.91%   +0.21%     
     Complexity       10       10              
   ============================================
     Files           132      133       +1     
     Lines          5108     5084      -24     
     Branches        638      638              
   ============================================
   - Hits           4020     4012       -8     
   + Misses          740      722      -18     
   - Partials        348      350       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...n/scala/org/apache/kyuubi/KyuubiSQLException.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9LeXV1YmlTUUxFeGNlcHRpb24uc2NhbGE=) | `86.36% <0.00%> (-1.00%)` | :arrow_down: |
   | [...la/org/apache/kyuubi/session/AbstractSession.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0Fic3RyYWN0U2Vzc2lvbi5zY2FsYQ==) | `95.50% <ø> (+2.95%)` | :arrow_up: |
   | [...scala/org/apache/kyuubi/operation/GetColumns.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldENvbHVtbnMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ala/org/apache/kyuubi/operation/GetFunctions.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldEZ1bmN0aW9ucy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
   | [...la/org/apache/kyuubi/operation/GetTableTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0dldFRhYmxlVHlwZXMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0t5dXViaU9wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `60.00% <60.00%> (+5.33%)` | :arrow_up: |
   | [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvb3BlcmF0aW9uL0t5dXViaU9wZXJhdGlvbi5zY2FsYQ==) | `52.72% <66.66%> (-4.85%)` | :arrow_down: |
   | [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L0t5dXViaVN5bmNUaHJpZnRDbGllbnQuc2NhbGE=) | `72.72% <72.72%> (ø)` | |
   | [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLW1haW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1Ymkvc2Vzc2lvbi9LeXV1YmlTZXNzaW9uSW1wbC5zY2FsYQ==) | `87.87% <83.33%> (-5.74%)` | :arrow_down: |
   | [...apache/kyuubi/service/AbstractBackendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL0Fic3RyYWN0QmFja2VuZFNlcnZpY2Uuc2NhbGE=) | `83.72% <100.00%> (-0.37%)` | :arrow_down: |
   | ... and [8 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/819/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [df8da82...8bb2c81](https://codecov.io/gh/apache/incubator-kyuubi/pull/819?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org