STREAMS-181 RSS Provider update

[Ryan Ebanks <ry...@gmail.com>]

I opened a pull request for the RSS Provider.

Renato, pointed out that it was broken, and there were no tests.  After
taking a look at it, I decided it needed a complete overhal. The previous
functionality would launch a thread for rss feed and would not
die/complete.  The new version does not hog resources as previous version
and includes tests.  There is small change to the constructor that may
break code for some people.

If you are interested in or use the RSS provider please comment on the pull
request and the proposed changes.
https://github.com/apache/incubator-streams/pull/95

-Ryan Ebanks

Re: STREAMS-181 RSS Provider update

[Renato Marroquín Mogrovejo <re...@gmail.com>]

So I couldn't wait, and I think everything looks really good, if anybody
could commit this, I would be happy :)
Thanks!


Renato M.

2014-09-25 22:45 GMT+02:00 Renato Marroquín Mogrovejo <
renatoj.marroquin@gmail.com>:

> Cool stuff Ryan! I will go over this tomorrow as it is almost midnight
> here.
> I had actually fixed the previous code by changing the provider's queue by
> a dequeue and then it was "sort of" working, but a first glance to the
> changes you are proposing look a lot better.
> Thanks!
>
>
> Renato M.
>
> 2014-09-25 21:21 GMT+02:00 Ryan Ebanks <ry...@gmail.com>:
>
>> I opened a pull request for the RSS Provider.
>>
>> Renato, pointed out that it was broken, and there were no tests.  After
>> taking a look at it, I decided it needed a complete overhal. The previous
>> functionality would launch a thread for rss feed and would not
>> die/complete.  The new version does not hog resources as previous version
>> and includes tests.  There is small change to the constructor that may
>> break code for some people.
>>
>> If you are interested in or use the RSS provider please comment on the
>> pull
>> request and the proposed changes.
>> https://github.com/apache/incubator-streams/pull/95
>>
>> -Ryan Ebanks
>>
>
>

Re: STREAMS-181 RSS Provider update

[Renato Marroquín Mogrovejo <re...@gmail.com>]

Cool stuff Ryan! I will go over this tomorrow as it is almost midnight here.
I had actually fixed the previous code by changing the provider's queue by
a dequeue and then it was "sort of" working, but a first glance to the
changes you are proposing look a lot better.
Thanks!


Renato M.

2014-09-25 21:21 GMT+02:00 Ryan Ebanks <ry...@gmail.com>:

> I opened a pull request for the RSS Provider.
>
> Renato, pointed out that it was broken, and there were no tests.  After
> taking a look at it, I decided it needed a complete overhal. The previous
> functionality would launch a thread for rss feed and would not
> die/complete.  The new version does not hog resources as previous version
> and includes tests.  There is small change to the constructor that may
> break code for some people.
>
> If you are interested in or use the RSS provider please comment on the pull
> request and the proposed changes.
> https://github.com/apache/incubator-streams/pull/95
>
> -Ryan Ebanks
>