[GitHub] trafficserver pull request #1299: TS-2888: remove vararg and format paramete...

[SolidWallOfCode <gi...@git.apache.org>]

Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1299#discussion_r99958838
  
    --- Diff: proxy/http/HttpTransact.cc ---
    @@ -775,15 +775,15 @@ HttpTransact::EndRemapRequest(State *s)
       // We must close this connection if client_connection_enabled == false //
       /////////////////////////////////////////////////////////////////////////
       if (!s->client_connection_enabled) {
    -    build_error_response(s, HTTP_STATUS_FORBIDDEN, "Access Denied", "access#denied", nullptr);
    +    build_error_response(s, HTTP_STATUS_FORBIDDEN, "Access Denied", "access#denied");
         s->reverse_proxy = false;
         goto done;
       }
       /////////////////////////////////////////////////////////////////
       // Check if remap plugin set HTTP return code and return body  //
       /////////////////////////////////////////////////////////////////
       if (s->http_return_code != HTTP_STATUS_NONE) {
    -    build_error_response(s, s->http_return_code, nullptr, nullptr, s->internal_msg_buffer_size ? s->internal_msg_buffer : nullptr);
    +    build_error_response(s, s->http_return_code, nullptr, nullptr);
    --- End diff --
    
    What happened to `internal_msg_buffer`? Can that no longer be set?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---