You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by ev...@apache.org on 2005/12/22 11:39:47 UTC
svn commit: r358553 - in /maven/continuum/trunk/continuum-webapp/src/main:
java/org/apache/maven/continuum/web/action/SummaryAction.java
webapp/summary.jsp
Author: evenisse
Date: Thu Dec 22 02:39:41 2005
New Revision: 358553
URL: http://svn.apache.org/viewcvs?rev=358553&view=rev
Log:
don't put object in request from action. We use <ww:set/> instead
Modified:
maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java
maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp
Modified: maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java
URL: http://svn.apache.org/viewcvs/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java?rev=358553&r1=358552&r2=358553&view=diff
==============================================================================
--- maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java (original)
+++ maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java Thu Dec 22 02:39:41 2005
@@ -27,6 +27,7 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.Iterator;
+import java.util.List;
import java.util.Map;
/**
@@ -39,8 +40,12 @@
private Continuum continuum;
private int nbSuccesses;
+
private int nbFailures;
+
private int nbErrors;
+
+ private List summary;
public String execute()
throws Exception
@@ -54,7 +59,7 @@
Map buildResultsInSuccess = continuum.getBuildResultsInSuccess();
- Collection summary = new ArrayList();
+ summary = new ArrayList();
for ( Iterator i = projects.iterator(); i.hasNext(); )
{
@@ -118,8 +123,6 @@
summary.add( model );
}
-
- ServletActionContext.getRequest().setAttribute( "projects", summary );
}
catch( Exception e )
{
@@ -142,5 +145,10 @@
public int getNbErrors()
{
return nbErrors;
+ }
+
+ public List getProjects()
+ {
+ return summary;
}
}
Modified: maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp
URL: http://svn.apache.org/viewcvs/maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp?rev=358553&r1=358552&r2=358553&view=diff
==============================================================================
--- maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp (original)
+++ maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp Thu Dec 22 02:39:41 2005
@@ -8,6 +8,7 @@
<body>
<div id="h3">
<h3><ww:text name="summary.section.title"/></h3>
+ <ww:set name="projects" value="projects" scope="request"/>
<ec:table items="projects"
var="project"
showExports="false"