You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by ji...@apache.org on 2009/09/17 16:39:29 UTC
svn commit: r816217 - /apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
Author: jim
Date: Thu Sep 17 14:39:29 2009
New Revision: 816217
URL: http://svn.apache.org/viewvc?rev=816217&view=rev
Log:
Using apr-util
Modified:
apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
Modified: apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
URL: http://svn.apache.org/viewvc/apr/apr/branches/1.4.x/locks/unix/proc_mutex.c?rev=816217&r1=816216&r2=816217&view=diff
==============================================================================
--- apr/apr/branches/1.4.x/locks/unix/proc_mutex.c (original)
+++ apr/apr/branches/1.4.x/locks/unix/proc_mutex.c Thu Sep 17 14:39:29 2009
@@ -18,7 +18,12 @@
#include "apr_strings.h"
#include "apr_arch_proc_mutex.h"
#include "apr_arch_file_io.h" /* for apr_mkstemp() */
-#include "apr_md5.h" /* for apr_md5() */
+#ifndef APR_MD5_DIGESTSIZE
+#define APR_MD5_DIGESTSIZE 16
+extern apr_status_t apr_md5(unsigned char digest[APR_MD5_DIGESTSIZE],
+ const void *input,
+ apr_size_t inputLen);
+#endif
APR_DECLARE(apr_status_t) apr_proc_mutex_destroy(apr_proc_mutex_t *mutex)
{
Re: svn commit: r816217 - /apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
William A. Rowe, Jr. wrote:
> Jeff Trawick wrote:
>>
>> are there other examples of apr depending on apr-util?
>
> No, my previous attempts were successfully vetoed, for good justifications.
>
> That was why I answered Neil that it is never intentional to have apr
> dependencies upon apr-util.
Actually I just remembered, it was apr_generate_random_bytes and the os
entropy questions that bit us last time :)
Re: svn commit: r816217 - /apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Jeff Trawick wrote:
> On Thu, Sep 17, 2009 at 10:39 AM, <jim@apache.org
> <ma...@apache.org>> wrote:
>
> Author: jim
> Date: Thu Sep 17 14:39:29 2009
> New Revision: 816217
>
> URL: http://svn.apache.org/viewvc?rev=816217&view=rev
> <http://svn.apache.org/viewvc?rev=816217&view=rev>
> Log:
> Using apr-util
>
> Modified:
> apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
>
>
> apr/locks using the still-separate apr-util just seems hokey/totally
> unexpected and brings in a surprising dependency
>
> are there other examples of apr depending on apr-util?
No, my previous attempts were successfully vetoed, for good justifications.
That was why I answered Neil that it is never intentional to have apr
dependencies upon apr-util.
Re: svn commit: r816217 - /apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
Posted by Guenter Knauf <fu...@apache.org>.
Hi,
Jim Jagielski schrieb:
> At least netware does... apr_ldap_rebind_init which
> is in apu... looking for more.
yes, thats probably because we did never split apr/apr-util into
separate libs but shipped all the time an aprlib which has apr-util
linked in statically; and I think it doesnt make much sense to break
this up now when we look at the future apr-2.0 which has them combined
anyway.
Gün.
Re: svn commit: r816217 - /apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Sep 17, 2009, at 10:50 AM, Jim Jagielski wrote:
>
> On Sep 17, 2009, at 10:43 AM, Jeff Trawick wrote:
>
>> On Thu, Sep 17, 2009 at 10:39 AM, <ji...@apache.org> wrote:
>> Author: jim
>> Date: Thu Sep 17 14:39:29 2009
>> New Revision: 816217
>>
>> URL: http://svn.apache.org/viewvc?rev=816217&view=rev
>> Log:
>> Using apr-util
>>
>> Modified:
>> apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
>>
>> apr/locks using the still-separate apr-util just seems hokey/
>> totally unexpected and brings in a surprising dependency
>>
>> are there other examples of apr depending on apr-util?
>>
>
> I'm looking into that...
At least netware does... apr_ldap_rebind_init which
is in apu... looking for more.
Re: svn commit: r816217 - /apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
Posted by Jim Jagielski <ji...@jaguNET.com>.
On Sep 17, 2009, at 10:43 AM, Jeff Trawick wrote:
> On Thu, Sep 17, 2009 at 10:39 AM, <ji...@apache.org> wrote:
> Author: jim
> Date: Thu Sep 17 14:39:29 2009
> New Revision: 816217
>
> URL: http://svn.apache.org/viewvc?rev=816217&view=rev
> Log:
> Using apr-util
>
> Modified:
> apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
>
> apr/locks using the still-separate apr-util just seems hokey/totally
> unexpected and brings in a surprising dependency
>
> are there other examples of apr depending on apr-util?
>
I'm looking into that... Agreed about the "should APR expect APU"
question; it's a good one.
Re: svn commit: r816217 - /apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
Posted by Jeff Trawick <tr...@gmail.com>.
On Thu, Sep 17, 2009 at 10:39 AM, <ji...@apache.org> wrote:
> Author: jim
> Date: Thu Sep 17 14:39:29 2009
> New Revision: 816217
>
> URL: http://svn.apache.org/viewvc?rev=816217&view=rev
> Log:
> Using apr-util
>
> Modified:
> apr/apr/branches/1.4.x/locks/unix/proc_mutex.c
>
apr/locks using the still-separate apr-util just seems hokey/totally
unexpected and brings in a surprising dependency
are there other examples of apr depending on apr-util?