You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "mbeckerle (via GitHub)" <gi...@apache.org> on 2023/10/14 03:51:16 UTC
[PR] WIP: Metadata walker for JAPI [daffodil]
mbeckerle opened a new pull request, #1092:
URL: https://github.com/apache/daffodil/pull/1092
For preliminary review.
Enables systems that want to interface tightly with Daffodil via JAPI, to walk the runtime schema information so as to construct their own corresponding metadata.
Done to enable Apache Drill but should be useful generally.
DAFFODIL-2832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Metadata walker for JAPI [daffodil]
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on code in PR #1092:
URL: https://github.com/apache/daffodil/pull/1092#discussion_r1362679258
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
+
+import org.apache.daffodil.japi.{ DataProcessor => JDataProcessor }
+import org.apache.daffodil.lib.exceptions.Assert
+import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType
+import org.apache.daffodil.runtime1.processors.{
+ ChoiceRuntimeData,
+ DataProcessor => SDataProcessor,
+ ElementRuntimeData,
+ ErrorERD,
+ SequenceRuntimeData,
+ TermRuntimeData,
+}
+
+/**
+ * Base class used by japi clients who want to walk the runtime schema information.
+ */
+abstract class RuntimeSchemaHandler() {
+
+ /**
+ * Called for simple type element declarations.
+ *
+ * @param qnameString
+ * @param primTypeName
+ * @param isArray only true if more than one occurrence is possible. Disjoint with isOptional
+ * @param isOptional true if 0 or 1 occurrence only. Allows for a different representation of optional from a 0..1 array
+ */
+ def elementSimple(
+ qnameString: String,
+ primTypeName: String,
+ isArray: Boolean,
+ isOptional: Boolean,
+ ): Unit
+
+ /**
+ * Called for complex type element declarations
+ *
+ * Subsequent calls will be for the model group making up the content
+ * of the element.
+ *
+ * @param qnameString
+ */
+ def startElementComplex(qnameString: String, isArray: Boolean, isOptional: Boolean): Unit
+ def endElementComplex(qnameString: String, isArray: Boolean, isOptional: Boolean): Unit
+
+ def startSequence(): Unit
+
+ def endSequence(): Unit
+
+ def startChoice(): Unit
+
+ def endChoice(): Unit
+
+}
+
+/**
+ * Walks the schema, but not the DSOM schema, it walks the RuntimeData objects that
+ * represent the DFDL schema at runtime.
+ *
+ * @param dp
+ */
+class RuntimeSchemaWalker(private val dp: SDataProcessor) {
+
+ // provided so that people can write various tests from JAPI only.
+ // we wouldn't need this otherwise.
+ def this(jdp: JDataProcessor) = this(jdp.getUnderlyingDataProcessor)
+
+ private lazy val rootERD = dp.ssrd.elementRuntimeData
+
+ def walk(handler: RuntimeSchemaHandler): Unit = {
+ walkTerm(handler, rootERD)
+ }
+
+ private def walkTerm(handler: RuntimeSchemaHandler, trd: TermRuntimeData): Unit = {
+ trd match {
+ case err: ErrorERD => Assert.invariantFailed("should not get ErrorERDs")
+ case erd: ElementRuntimeData => walkElement(handler, erd)
+ case srd: SequenceRuntimeData => walkSequence(handler, srd)
+ case crd: ChoiceRuntimeData => walkChoice(handler, crd)
+ case _ => Assert.invariantFailed(s"unrecognized TermRuntimeData subtype: $trd")
+ }
+ }
+
+ private def walkElement(handler: RuntimeSchemaHandler, erd: ElementRuntimeData): Unit = {
+ if (erd.optComplexTypeModelGroupRuntimeData.isDefined)
+ walkComplexElement(handler, erd)
+ else
+ walkSimpleElement(handler, erd)
+ }
+
+ private def walkComplexElement(
+ handler: RuntimeSchemaHandler,
+ erd: ElementRuntimeData,
+ ): Unit = {
+ val qname = erd.namedQName.toQNameString
+ val isArray = erd.isArray
+ val isOptional = erd.isOptional
+ val mgrd = erd.optComplexTypeModelGroupRuntimeData.getOrElse {
+ Assert.invariantFailed("not a complex type element")
+ }
+ handler.startElementComplex(qname, isArray, isOptional)
+ walkTerm(handler, mgrd)
+ handler.endElementComplex(qname, isArray, isOptional)
+ }
+
+ private def walkSimpleElement(
+ handler: RuntimeSchemaHandler,
+ erd: ElementRuntimeData,
+ ): Unit = {
+ val qname = erd.namedQName.toQNameString
+ val isArray = erd.isArray
+ val isOptional = erd.isOptional
+ val primType: PrimType = erd.optPrimType.getOrElse {
+ erd.optSimpleTypeRuntimeData.map { _.primType }.get
+ }
+ handler.elementSimple(qname, primType.toString, isArray, isOptional)
+ }
+
+ private def walkSequence(handler: RuntimeSchemaHandler, srd: SequenceRuntimeData): Unit = {
+ handler.startSequence()
+ srd.groupMembers.map { trd =>
+ walkTerm(handler, trd)
+ }
+ handler.endSequence()
+ }
+
+ private def walkChoice(handler: RuntimeSchemaHandler, crd: ChoiceRuntimeData): Unit = {
+ handler.startChoice()
+ crd.groupMembers.map { trd =>
+ walkTerm(handler, trd)
+ }
+ handler.endChoice()
+ }
Review Comment:
Be sure to make one test use a hidden group
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala:
##########
@@ -514,6 +507,11 @@ class DataProcessor private[japi] (private var dp: SDataProcessor)
*/
def save(output: WritableByteChannel): Unit = dp.save(output)
+ def walkRuntimeSchema(handler: RuntimeSchemaHandler): Unit = {
+ val walker = new RuntimeSchemaWalker(dp)
Review Comment:
Right, so I think that decision, to use a DSOM walker for NiFi, was a mistake.
When we are interfacing Daffodil's runtime-1 output to a different data fabric, it makes sense to use the metadata structures of runtime-1 rather than DSOM. Everything we need seems to be available on the RuntimeData objects. We don't need the complexity of DSOM.
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
Review Comment:
How about japix which we document as japi-experimental?
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
+
+import org.apache.daffodil.japi.{ DataProcessor => JDataProcessor }
+import org.apache.daffodil.lib.exceptions.Assert
+import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType
+import org.apache.daffodil.runtime1.processors.{
+ ChoiceRuntimeData,
+ DataProcessor => SDataProcessor,
+ ElementRuntimeData,
+ ErrorERD,
+ SequenceRuntimeData,
+ TermRuntimeData,
+}
+
+/**
+ * Base class used by japi clients who want to walk the runtime schema information.
+ */
+abstract class RuntimeSchemaHandler() {
+
+ /**
+ * Called for simple type element declarations.
+ *
+ * @param qnameString
+ * @param primTypeName
+ * @param isArray only true if more than one occurrence is possible. Disjoint with isOptional
+ * @param isOptional true if 0 or 1 occurrence only. Allows for a different representation of optional from a 0..1 array
+ */
+ def elementSimple(
+ qnameString: String,
+ primTypeName: String,
+ isArray: Boolean,
+ isOptional: Boolean,
+ ): Unit
+
+ /**
+ * Called for complex type element declarations
+ *
+ * Subsequent calls will be for the model group making up the content
+ * of the element.
+ *
+ * @param qnameString
+ */
+ def startElementComplex(qnameString: String, isArray: Boolean, isOptional: Boolean): Unit
+ def endElementComplex(qnameString: String, isArray: Boolean, isOptional: Boolean): Unit
+
+ def startSequence(): Unit
+
+ def endSequence(): Unit
+
+ def startChoice(): Unit
+
+ def endChoice(): Unit
+
+}
+
+/**
+ * Walks the schema, but not the DSOM schema, it walks the RuntimeData objects that
+ * represent the DFDL schema at runtime.
+ *
+ * @param dp
+ */
+class RuntimeSchemaWalker(private val dp: SDataProcessor) {
+
+ // provided so that people can write various tests from JAPI only.
+ // we wouldn't need this otherwise.
+ def this(jdp: JDataProcessor) = this(jdp.getUnderlyingDataProcessor)
+
+ private lazy val rootERD = dp.ssrd.elementRuntimeData
+
+ def walk(handler: RuntimeSchemaHandler): Unit = {
+ walkTerm(handler, rootERD)
+ }
+
+ private def walkTerm(handler: RuntimeSchemaHandler, trd: TermRuntimeData): Unit = {
Review Comment:
I will have to verify the RuntimeSchemaWalker (or whatever we end up calling it) does not walk into hidden groups. We don't need the hidden groups because the infoset outputter from Daffodil via JAPI already has them removed from it. So we never will encounter an actual element for conversion to Drill that is hidden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Metadata walker for JAPI [daffodil]
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on code in PR #1092:
URL: https://github.com/apache/daffodil/pull/1092#discussion_r1359111033
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
Review Comment:
apache banner
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
+
+import org.apache.daffodil.japi.{ DataProcessor => JDataProcessor }
+import org.apache.daffodil.lib.exceptions.Assert
+import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType
+import org.apache.daffodil.runtime1.processors.{
+ ChoiceRuntimeData,
+ DataProcessor => SDataProcessor,
+ ElementRuntimeData,
+ ErrorERD,
+ SequenceRuntimeData,
+ TermRuntimeData,
+}
+
+/**
+ * Base class used by japi clients who want to walk the runtime schema information.
+ */
+abstract class RuntimeSchemaHandler() {
Review Comment:
Name: make clear this is walking the schema, but not the DSOM schema, it's walking the schema as the Runtime1 sees it, which is the metadata needed to interface Runtime1 with other data frameworks. It's the metadata of the data that will be presented to that framework.
"RuntimeSchema" doesn't seem sufficient.
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
+
+import org.apache.daffodil.japi.{ DataProcessor => JDataProcessor }
+import org.apache.daffodil.lib.exceptions.Assert
+import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType
+import org.apache.daffodil.runtime1.processors.{
+ ChoiceRuntimeData,
+ DataProcessor => SDataProcessor,
+ ElementRuntimeData,
+ ErrorERD,
+ SequenceRuntimeData,
+ TermRuntimeData,
+}
+
+/**
+ * Base class used by japi clients who want to walk the runtime schema information.
+ */
+abstract class RuntimeSchemaHandler() {
+
+ /**
+ * Called for simple type element declarations.
+ *
+ * @param qnameString
+ * @param primTypeName
+ * @param isArray only true if more than one occurrence is possible. Disjoint with isOptional
+ * @param isOptional true if 0 or 1 occurrence only. Allows for a different representation of optional from a 0..1 array
+ */
+ def elementSimple(
Review Comment:
Name: simpleElement ?
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
+
+import org.apache.daffodil.japi.{ DataProcessor => JDataProcessor }
+import org.apache.daffodil.lib.exceptions.Assert
+import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType
+import org.apache.daffodil.runtime1.processors.{
+ ChoiceRuntimeData,
+ DataProcessor => SDataProcessor,
+ ElementRuntimeData,
+ ErrorERD,
+ SequenceRuntimeData,
+ TermRuntimeData,
+}
+
+/**
+ * Base class used by japi clients who want to walk the runtime schema information.
+ */
+abstract class RuntimeSchemaHandler() {
+
+ /**
+ * Called for simple type element declarations.
+ *
+ * @param qnameString
+ * @param primTypeName
+ * @param isArray only true if more than one occurrence is possible. Disjoint with isOptional
+ * @param isOptional true if 0 or 1 occurrence only. Allows for a different representation of optional from a 0..1 array
+ */
+ def elementSimple(
+ qnameString: String,
+ primTypeName: String,
+ isArray: Boolean,
+ isOptional: Boolean,
+ ): Unit
+
+ /**
+ * Called for complex type element declarations
+ *
+ * Subsequent calls will be for the model group making up the content
+ * of the element.
+ *
+ * @param qnameString
+ */
+ def startElementComplex(qnameString: String, isArray: Boolean, isOptional: Boolean): Unit
+ def endElementComplex(qnameString: String, isArray: Boolean, isOptional: Boolean): Unit
+
+ def startSequence(): Unit
+
+ def endSequence(): Unit
+
+ def startChoice(): Unit
+
+ def endChoice(): Unit
+
+}
+
+/**
+ * Walks the schema, but not the DSOM schema, it walks the RuntimeData objects that
+ * represent the DFDL schema at runtime.
+ *
+ * @param dp
+ */
+class RuntimeSchemaWalker(private val dp: SDataProcessor) {
+
+ // provided so that people can write various tests from JAPI only.
+ // we wouldn't need this otherwise.
+ def this(jdp: JDataProcessor) = this(jdp.getUnderlyingDataProcessor)
+
+ private lazy val rootERD = dp.ssrd.elementRuntimeData
+
+ def walk(handler: RuntimeSchemaHandler): Unit = {
+ walkTerm(handler, rootERD)
+ }
+
+ private def walkTerm(handler: RuntimeSchemaHandler, trd: TermRuntimeData): Unit = {
+ trd match {
+ case err: ErrorERD => Assert.invariantFailed("should not get ErrorERDs")
+ case erd: ElementRuntimeData => walkElement(handler, erd)
+ case srd: SequenceRuntimeData => walkSequence(handler, srd)
+ case crd: ChoiceRuntimeData => walkChoice(handler, crd)
+ case _ => Assert.invariantFailed(s"unrecognized TermRuntimeData subtype: $trd")
+ }
+ }
+
+ private def walkElement(handler: RuntimeSchemaHandler, erd: ElementRuntimeData): Unit = {
+ if (erd.optComplexTypeModelGroupRuntimeData.isDefined)
+ walkComplexElement(handler, erd)
+ else
+ walkSimpleElement(handler, erd)
+ }
+
+ private def walkComplexElement(
+ handler: RuntimeSchemaHandler,
+ erd: ElementRuntimeData,
+ ): Unit = {
+ val qname = erd.namedQName.toQNameString
+ val isArray = erd.isArray
+ val isOptional = erd.isOptional
+ val mgrd = erd.optComplexTypeModelGroupRuntimeData.getOrElse {
+ Assert.invariantFailed("not a complex type element")
+ }
+ handler.startElementComplex(qname, isArray, isOptional)
+ walkTerm(handler, mgrd)
+ handler.endElementComplex(qname, isArray, isOptional)
+ }
+
+ private def walkSimpleElement(
+ handler: RuntimeSchemaHandler,
+ erd: ElementRuntimeData,
+ ): Unit = {
+ val qname = erd.namedQName.toQNameString
+ val isArray = erd.isArray
+ val isOptional = erd.isOptional
+ val primType: PrimType = erd.optPrimType.getOrElse {
+ erd.optSimpleTypeRuntimeData.map { _.primType }.get
+ }
+ handler.elementSimple(qname, primType.toString, isArray, isOptional)
+ }
+
+ private def walkSequence(handler: RuntimeSchemaHandler, srd: SequenceRuntimeData): Unit = {
+ handler.startSequence()
+ srd.groupMembers.map { trd =>
+ walkTerm(handler, trd)
+ }
+ handler.endSequence()
+ }
+
+ private def walkChoice(handler: RuntimeSchemaHandler, crd: ChoiceRuntimeData): Unit = {
+ handler.startChoice()
+ crd.groupMembers.map { trd =>
+ walkTerm(handler, trd)
+ }
+ handler.endChoice()
+ }
Review Comment:
Needs unit tests or other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Metadata walker for JAPI [daffodil]
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #1092:
URL: https://github.com/apache/daffodil/pull/1092#discussion_r1360822467
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala:
##########
@@ -401,6 +388,12 @@ class DataProcessor private[japi] (private var dp: SDataProcessor)
extends WithDiagnostics(dp)
with Serializable {
+ /**
+ * For use by the JAPI implementation only.
+ * @return the underlying data processor
+ */
+ private [japi] def getUnderlyingDataProcessor = dp
Review Comment:
Does scala's package private thing apply to the generated java docs? If not, we might want to add a doc that says this shouldn't be used externally.
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
Review Comment:
I wonder if this wants to be in some experimental namespace? I consider japi and sapi as being very strict about backwards compatibility. It might be nice to put this in a namespace that makes it clear this maybe not be final and is subject to change--I don't want to tie us down to an API that maybe isn't completely fleshed out.
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/Daffodil.scala:
##########
@@ -514,6 +507,11 @@ class DataProcessor private[japi] (private var dp: SDataProcessor)
*/
def save(output: WritableByteChannel): Unit = dp.save(output)
+ def walkRuntimeSchema(handler: RuntimeSchemaHandler): Unit = {
+ val walker = new RuntimeSchemaWalker(dp)
Review Comment:
I think we already have a couple different walkers. We have an` AbsractDSOMWalker` that is used by the experimental NiFi Daffodil Record processor. We also have the walker used by the C Code generator. I think they walk different things. Does this also walk something different? Is there any chance these could all be combined? Seems we might be doing something wrong if we have a bunch of different ways to walk different things?
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
+
+import org.apache.daffodil.japi.{ DataProcessor => JDataProcessor }
+import org.apache.daffodil.lib.exceptions.Assert
+import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType
+import org.apache.daffodil.runtime1.processors.{
+ ChoiceRuntimeData,
+ DataProcessor => SDataProcessor,
+ ElementRuntimeData,
+ ErrorERD,
+ SequenceRuntimeData,
+ TermRuntimeData,
+}
+
+/**
+ * Base class used by japi clients who want to walk the runtime schema information.
+ */
+abstract class RuntimeSchemaHandler() {
+
+ /**
+ * Called for simple type element declarations.
+ *
+ * @param qnameString
+ * @param primTypeName
+ * @param isArray only true if more than one occurrence is possible. Disjoint with isOptional
+ * @param isOptional true if 0 or 1 occurrence only. Allows for a different representation of optional from a 0..1 array
+ */
+ def elementSimple(
+ qnameString: String,
+ primTypeName: String,
+ isArray: Boolean,
+ isOptional: Boolean,
+ ): Unit
+
+ /**
+ * Called for complex type element declarations
+ *
+ * Subsequent calls will be for the model group making up the content
+ * of the element.
+ *
+ * @param qnameString
+ */
+ def startElementComplex(qnameString: String, isArray: Boolean, isOptional: Boolean): Unit
+ def endElementComplex(qnameString: String, isArray: Boolean, isOptional: Boolean): Unit
+
+ def startSequence(): Unit
+
+ def endSequence(): Unit
+
+ def startChoice(): Unit
+
+ def endChoice(): Unit
+
+}
+
+/**
+ * Walks the schema, but not the DSOM schema, it walks the RuntimeData objects that
+ * represent the DFDL schema at runtime.
+ *
+ * @param dp
+ */
+class RuntimeSchemaWalker(private val dp: SDataProcessor) {
+
+ // provided so that people can write various tests from JAPI only.
+ // we wouldn't need this otherwise.
+ def this(jdp: JDataProcessor) = this(jdp.getUnderlyingDataProcessor)
+
+ private lazy val rootERD = dp.ssrd.elementRuntimeData
+
+ def walk(handler: RuntimeSchemaHandler): Unit = {
+ walkTerm(handler, rootERD)
+ }
+
+ private def walkTerm(handler: RuntimeSchemaHandler, trd: TermRuntimeData): Unit = {
Review Comment:
I'm not sure where the logic should be, but one difference between this walker and the DSOM walker is the DSOM walker has a `isHidden` boolean to avoid walking into hidden group refs that won't end up in the infoset. Does this need something similar, or beause this is walking runtime1 constructs are hidden elements implicitly skipped over?
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
+
+import org.apache.daffodil.japi.{ DataProcessor => JDataProcessor }
+import org.apache.daffodil.lib.exceptions.Assert
+import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType
+import org.apache.daffodil.runtime1.processors.{
+ ChoiceRuntimeData,
+ DataProcessor => SDataProcessor,
+ ElementRuntimeData,
+ ErrorERD,
+ SequenceRuntimeData,
+ TermRuntimeData,
+}
+
+/**
+ * Base class used by japi clients who want to walk the runtime schema information.
+ */
+abstract class RuntimeSchemaHandler() {
Review Comment:
We already have a DSOM walker used by NiFi, is that not sufficient? Can you add comments about how the two differ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Metadata walker for JAPI [daffodil]
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on code in PR #1092:
URL: https://github.com/apache/daffodil/pull/1092#discussion_r1359949586
##########
daffodil-japi/src/main/scala/org/apache/daffodil/japi/schema/RuntimeSchemaWalker.scala:
##########
@@ -0,0 +1,135 @@
+package org.apache.daffodil.japi.schema
+
+import org.apache.daffodil.japi.{ DataProcessor => JDataProcessor }
+import org.apache.daffodil.lib.exceptions.Assert
+import org.apache.daffodil.runtime1.dpath.NodeInfo.PrimType
+import org.apache.daffodil.runtime1.processors.{
+ ChoiceRuntimeData,
+ DataProcessor => SDataProcessor,
+ ElementRuntimeData,
+ ErrorERD,
+ SequenceRuntimeData,
+ TermRuntimeData,
Review Comment:
In standard Daffodil code style, each type is imported in a separate import statement (not collected and grouped like this).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Metadata walker for JAPI [daffodil]
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on PR #1092:
URL: https://github.com/apache/daffodil/pull/1092#issuecomment-1803132424
Closing. Superceded by PR:
https://github.com/apache/daffodil/pull/1112
Relevant comments on this have been recorded there with links back to this PR for context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] WIP: Metadata walker for JAPI [daffodil]
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle closed pull request #1092: WIP: Metadata walker for JAPI
URL: https://github.com/apache/daffodil/pull/1092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org