You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/30 08:47:56 UTC

[GitHub] [spark] HyukjinKwon edited a comment on pull request #30198: [SPARK-33297][BUILD] Switch to use flat class loader strategy in SBT

HyukjinKwon edited a comment on pull request #30198:
URL: https://github.com/apache/spark/pull/30198#issuecomment-719425435


   @maropu, I am not very sure. From reading the doc, seems it dose because it will change a class loader, within SBT, that is used during `test` tasks. I think the SBT maintainer suggested this way because he suspects that there's something wrong in the reused class loader. So by changing it to `Flat`, it won't be reused anymore.
   
   Ideally it should not have any behaviour change even with the default `ScalaLibrary` but seems it did (?).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org