Re: [PR] [Managed Iceberg] Make manifest file writes and commits more efficient [beam]

["chamikaramj (via GitHub)" <gi...@apache.org>]

chamikaramj commented on code in PR #32666:
URL: https://github.com/apache/beam/pull/32666#discussion_r1792217431


##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/WriteGroupedRowsToFiles.java:
##########
@@ -105,13 +108,13 @@ public void processElement(
         }
       }
 
-      List<ManifestFile> manifestFiles =
-          Preconditions.checkNotNull(writer.getManifestFiles().get(windowedDestination));
-      for (ManifestFile manifestFile : manifestFiles) {
+      List<SerializableDataFile> serializableDataFiles =

Review Comment:
   Sounds good. No OOM related concerns then. Resolving.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org