You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Timo Walther (JIRA)" <ji...@apache.org> on 2018/02/14 10:06:00 UTC

[jira] [Comment Edited] (FLINK-8538) Add a Kafka table source factory with JSON format support

    [ https://issues.apache.org/jira/browse/FLINK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16363724#comment-16363724 ] 

Timo Walther edited comment on FLINK-8538 at 2/14/18 10:05 AM:
---------------------------------------------------------------

[~xccui] good point maybe we should make those classes more Java-friendly then. Everything that is used outside of {{flink-table}} should be Java-like. That's why {{TableSourceFactory}} uses Java classes, for instance. Btw. I will open a PR for the new JSON parser and module {{flink-json}} today. What is your time schedule? Do you think you can finish this until Friday (your timezone) such that I can finalize it and merge it before the feature freeze?


was (Author: twalthr):
[~xccui] good point maybe we should make those classes more Java-friendly then. Everything that is used outside of {{flink-table}} should be Java-like. That's why {{TableSourceFactory}} uses Java classes, for instance. Btw. I will open a PR for the new JSON parser and module {{flink-json}}. What is your time schedule? Do you think you can finish this until Friday (your timezone) such that I can finalize it and merge it before the feature freeze?

> Add a Kafka table source factory with JSON format support
> ---------------------------------------------------------
>
>                 Key: FLINK-8538
>                 URL: https://issues.apache.org/jira/browse/FLINK-8538
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>            Priority: Major
>
> Similar to CSVTableSourceFactory a Kafka table source factory for JSON should be added. This issue includes improving the existing JSON descriptor with validation that can be used for other connectors as well. It is up for discussion if we want to split the KafkaJsonTableSource into connector and format such that we can reuse the format for other table sources as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)