[GitHub] [incubator-iotdb] jixuan1989 commented on issue #726: Made all tests Locale Invariant by always explicitly defaulting to Lo…

[GitBox <gi...@apache.org>]

jixuan1989 commented on issue #726: Made all tests Locale Invariant by always explicitly defaulting to Lo…
URL: https://github.com/apache/incubator-iotdb/pull/726#issuecomment-572870968
 
 
   > Thanks for the PR @JulianFeinauer
   > The PR looks good to me for fix this issue, I only left one comment for simple the code change and one suggestion as follows:
   > 
   > I checked the entire project and found that `String.format` is used in many places(not only in test code). We are fortunate to find this `Local` problem in ITCase, but we cannot rule out that there are unpredictable problems hidden in other places, so I think would be better make a util similar with `String.format` in IoTDB , and set the configuration we need in the util, such as `Local` information, so that even if other problems are found in the future, we can fix it as a whole by modifying one place.
   > 
   > What do you think? @JulianFeinauer @jixuan1989
   
   I  think many String.format() is used for log. Because all messages are in English, I wonder why a Locale is needed... 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services