You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/07/26 02:15:13 UTC
[GitHub] [incubator-pinot] sunny209868 commented on a change in pull request
#4469: Add crtl auto complete sql on query-console
sunny209868 commented on a change in pull request #4469: Add crtl auto complete sql on query-console
URL: https://github.com/apache/incubator-pinot/pull/4469#discussion_r307565586
##########
File path: pinot-controller/src/main/resources/static/js/lib/codemirror/hint/sql-hint.js
##########
@@ -0,0 +1,322 @@
+/*
Review comment:
Ok, I don't see through because there is no checks apache header, so direct copy apache header from the controller/src/main/resources/static/css/lib/codemirror-hint.css and controller/src/main/resources/static/js/init.js. Now, I remove apache header
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org