[GitHub] [accumulo] ctubbsii commented on a change in pull request #2513: remove not needed string concatenation

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2513:
URL: https://github.com/apache/accumulo/pull/2513#discussion_r810693890



##########
File path: server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/external/flot/jquery.flot.time.js
##########
@@ -145,8 +145,8 @@ API.txt for details.
                     case 's': c = "" + formatSubSeconds(d.getMilliseconds(), d.getMicroseconds(), decimals); break;
                     case 'y': c = leftPad(d.getFullYear() % 100); break;
                     case 'Y': c = "" + d.getFullYear(); break;
-                    case 'p': c = (isAM) ? ("" + "am") : ("" + "pm"); break;
-                    case 'P': c = (isAM) ? ("" + "AM") : ("" + "PM"); break;
+                    case 'p': c = (isAM) ? ("am") : ("pm"); break;
+                    case 'P': c = (isAM) ? ("AM") : ("PM"); break;

Review comment:
       This file should not be changed, because it's a third party library file that we've bundled. It should stay byte-for-byte equivalent to the upstream source.

##########
File path: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/LruBlockCacheConfiguration.java
##########
@@ -114,7 +114,7 @@ public LruBlockCacheConfiguration(Configuration conf, CacheType type) {
 
     if (this.getSingleFactor() + this.getMultiFactor() + this.getMemoryFactor() != 1) {
       throw new IllegalArgumentException(
-          "Single, multi, and memory factors " + " should total 1.0");
+          "Single, multi, and memory factors  should total 1.0");

Review comment:
       Looks like this one revealed an extra space:
   ```suggestion
             "Single, multi, and memory factors should total 1.0");
   ```

##########
File path: shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java
##########
@@ -385,7 +385,7 @@ public Options getOptions() {
     optEndRowExclusive.setArgName("end-exclusive");
     scanOptRow = new Option("r", "row", true, "row to scan");
     scanOptColumns = new Option("c", "columns", true,
-        "comma-separated columns.This" + " option is mutually exclusive with cf and cq");
+        "comma-separated columns.This option is mutually exclusive with cf and cq");

Review comment:
       Might as well fix this while in here:
   
   ```suggestion
           "comma-separated columns. This option is mutually exclusive with cf and cq");
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org