You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Evgueni Brevnov (JIRA)" <ji...@apache.org> on 2006/12/20 14:59:21 UTC

[jira] Created: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

[drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
--------------------------------------------------------------------------------

                 Key: HARMONY-2817
                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
             Project: Harmony
          Issue Type: Bug
          Components: DRLVM
            Reporter: Evgueni Brevnov
         Attachments: java_shutdown_fix.patch

Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2817?page=comments#action_12460202 ] 
            
Gregory Shimansky commented on HARMONY-2817:
--------------------------------------------

I tried the updated patch. It still causes problems for me on windows. The test gc.LOS crashes on interpreter somewhere in GC.

On x86_64 SuSE9 stress.Sync hanged again. It hangs on JIT too after printing PASSED. Note I've used powerful 4 CPU with HT (8 logical processors) server for x86_64, maybe we have some race condition which is reproducible only when a lot of stuff works in parallel.

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: java_shutdown_fix.patch, java_shutdown_fix2.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2817?page=all ]

Gregory Shimansky resolved HARMONY-2817.
----------------------------------------

    Resolution: Fixed

Patch applied at 489694. Please check that it was applied as expected.

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: java_shutdown_fix.patch, java_shutdown_fix2.patch, java_shutdown_fix3.patch, java_shutdown_fix4.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2817?page=all ]

Evgueni Brevnov updated HARMONY-2817:
-------------------------------------

    Attachment: java_shutdown_fix2.patch

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: java_shutdown_fix.patch, java_shutdown_fix2.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2817?page=comments#action_12460077 ] 
            
Gregory Shimansky commented on HARMONY-2817:
--------------------------------------------

The patch makes new smoke tests to hang (on Linux ia32) and crash (on Windows XP) on interpreter. Please check these tests with it. I can give the details if you need. I've reverted the changes and smoke tests on interpreter work again.

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: java_shutdown_fix.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2817?page=comments#action_12460187 ] 
            
Evgueni Brevnov commented on HARMONY-2817:
------------------------------------------

Aha, I see. Here is an updated patch java_shutdown_fix2.patch. I passed somke tests on Win2003-32bit & SUSE9-32bit. I will ask Elena to test this patch more thoroughly. Lets wait to see if everything is OK....

Evgueni


> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: java_shutdown_fix.patch, java_shutdown_fix2.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2817?page=all ]

Gregory Shimansky reassigned HARMONY-2817:
------------------------------------------

    Assignee: Gregory Shimansky

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: java_shutdown_fix.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Elena Semukhina (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2817?page=all ]

Elena Semukhina updated HARMONY-2817:
-------------------------------------

    Attachment: H-2817_debug_info.txt

I still see rare hangs of stress.Sync in the interpreter mode. I attached the file with debug info for linux ia32 gcc debug build.



> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: H-2817_debug_info.txt, java_shutdown_fix.patch, java_shutdown_fix2.patch, java_shutdown_fix3.patch, java_shutdown_fix4.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2817?page=all ]

Evgueni Brevnov updated HARMONY-2817:
-------------------------------------

    Attachment: java_shutdown_fix3.patch

Gregory,

I believe this patch will fix your crash on interpreter. It turned out that "interp_resolve_class" enables thread suspention inside even though it is called is susend disabled state. So the following code is not safe:

hythread_suspend_disable()
obj = ObjectHandle->object;
interp_resolve_class();
ObjectHandle->object = obj;
hythread_suspend_disable()

I think "interp_resolve_class" should be fixed in the future....

Note: stress.Sync still hangs on JIT. I will investigate it separately.

Evgueni

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: java_shutdown_fix.patch, java_shutdown_fix2.patch, java_shutdown_fix3.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2817?page=comments#action_12460238 ] 
            
Evgueni Brevnov commented on HARMONY-2817:
------------------------------------------

Gregory,

Hmm.... it is pitty we have a crash on the interpreter. I'll look through the patch once again to see where the problem is.

About stress.Sync. I didn't change the behaviour on JIT at all (almost :-)). This patch should affect interpreter only. Yes, stress.Sync hangs for me sometimes :-(....This needs additional investigation....It may turn out to be a JIT specific problem....IMHO This should not prevent us from commiting this patch as soon as interpreter is OK. 

BTW.. I've observed hangs of gc.LOS. It appeared to be hanging inside system library. Seems like we still have problems with native locks.

Evgueni

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: java_shutdown_fix.patch, java_shutdown_fix2.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463261 ] 

Evgueni Brevnov commented on HARMONY-2817:
------------------------------------------

Elena,

I looked at the dump file provided by you. The problem you met is connected with safe point callbacks implementation. A deadlock you have is described under 1 item in the https://issues.apache.org/jira/browse/HARMONY-2648.

Evgueni

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: H-2817_debug_info.txt, java_shutdown_fix.patch, java_shutdown_fix2.patch, java_shutdown_fix3.patch, java_shutdown_fix4.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2817?page=comments#action_12461186 ] 
            
Gregory Shimansky commented on HARMONY-2817:
--------------------------------------------

I've done a nightly run of this test on interpreter on 4 CPU SuSE9 linux server. For me this test passed 3320 times and still continued to run when I killed it. Maybe there should be more specific information about how to catch this bug.

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: H-2817_debug_info.txt, java_shutdown_fix.patch, java_shutdown_fix2.patch, java_shutdown_fix3.patch, java_shutdown_fix4.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2817?page=all ]

Evgueni Brevnov updated HARMONY-2817:
-------------------------------------

    Attachment: java_shutdown_fix4.patch

Huh... I finally found the reason why stress.Sync hangs. It turned out to be a problem with asynchronious exceptions which caused thread to exit without releasing monitors. Fixed in java_shutdown_fix4.patch. DRLVM tests are OK on Win2003-ia32 & SUSE9-32. stress.Sync consequently passed 160 times on JIT & Interpreter on SUSE10 16-logical processors.

Evgueni

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: java_shutdown_fix.patch, java_shutdown_fix2.patch, java_shutdown_fix3.patch, java_shutdown_fix4.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky closed HARMONY-2817.
--------------------------------------


No response, assuming ok.

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>            Assignee: Gregory Shimansky
>         Attachments: H-2817_debug_info.txt, java_shutdown_fix.patch, java_shutdown_fix2.patch, java_shutdown_fix3.patch, java_shutdown_fix4.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-2817) [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.

Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2817?page=all ]

Evgueni Brevnov updated HARMONY-2817:
-------------------------------------

    Attachment: java_shutdown_fix.patch

> [drlvm][interpreter] Exception propogation changed when VM is in shutdwon stage.
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-2817
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2817
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Evgueni Brevnov
>         Attachments: java_shutdown_fix.patch
>
>
> Before exception is propogated up to the stack the "finally" block must be called to release monitors.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira