You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2022/05/04 01:47:11 UTC

[servicecomb-java-chassis] branch master updated: [SCB-2472] Fix spotbugs EQ_UNUSUAL (#2808)

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new 4fd7d1081 [SCB-2472] Fix spotbugs EQ_UNUSUAL (#2808)
4fd7d1081 is described below

commit 4fd7d108112d67a6bc9834a439ba5d62a69171fd
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Wed May 4 09:47:06 2022 +0800

    [SCB-2472] Fix spotbugs EQ_UNUSUAL (#2808)
---
 ci/spotbugs/exclude.xml                            |  4 ---
 .../internal/bean/ArgumentsBeanDescriptor.java     | 39 ----------------------
 2 files changed, 43 deletions(-)

diff --git a/ci/spotbugs/exclude.xml b/ci/spotbugs/exclude.xml
index b6d4626b9..e3a4c712a 100644
--- a/ci/spotbugs/exclude.xml
+++ b/ci/spotbugs/exclude.xml
@@ -71,10 +71,6 @@
         <Bug pattern="EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC"/>
     </Match>
 
-    <Match>
-        <Bug pattern="EQ_UNUSUAL"/>
-    </Match>
-
     <Match>
         <Bug pattern="ICAST_IDIV_CAST_TO_DOUBLE"/>
     </Match>
diff --git a/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/bean/ArgumentsBeanDescriptor.java b/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/bean/ArgumentsBeanDescriptor.java
deleted file mode 100644
index dba42ac15..000000000
--- a/foundations/foundation-protobuf/src/main/java/org/apache/servicecomb/foundation/protobuf/internal/bean/ArgumentsBeanDescriptor.java
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.servicecomb.foundation.protobuf.internal.bean;
-
-import com.fasterxml.jackson.databind.type.SimpleType;
-
-public class ArgumentsBeanDescriptor extends SimpleType {
-  private static final long serialVersionUID = 1L;
-
-  private final BeanDescriptor beanDescriptor;
-
-  public ArgumentsBeanDescriptor(BeanDescriptor beanDescriptor) {
-    super(ArgumentsBeanDescriptor.class);
-    this.beanDescriptor = beanDescriptor;
-  }
-
-  public BeanDescriptor getBeanDescriptor() {
-    return beanDescriptor;
-  }
-
-  @Override
-  public boolean equals(Object o) {
-    throw new IllegalStateException("DO NOT invoke this method");
-  }
-}