You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Commit Tag Bot (JIRA)" <ji...@apache.org> on 2013/03/22 17:39:17 UTC
[jira] [Commented] (LUCENE-4362) ban tab-indented source
[ https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610820#comment-13610820 ]
Commit Tag Bot commented on LUCENE-4362:
----------------------------------------
[branch_4x commit] Robert Muir
http://svn.apache.org/viewvc?view=revision&revision=1386689
LUCENE-4362: add the check to build.xml
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch, LUCENE-4362.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch, LUCENE-4362_trunk.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org