[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5694: HDFS-17028. RBF: Optimize debug logs of class ConnectionPool and other related class.

["ayushtkn (via GitHub)" <gi...@apache.org>]

ayushtkn commented on code in PR #5694:
URL: https://github.com/apache/hadoop/pull/5694#discussion_r1215139609


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/ConnectionManager.java:
##########
@@ -482,7 +482,7 @@ public void run() {
                   pool.getMaxSize(), pool);
             }
           } catch (IOException e) {
-            LOG.error("Cannot create a new connection", e);
+            LOG.error("Cannot create a new connection for {} {}", pool, e.toString());

Review Comment:
   Should have stayed
   ```
   LOG.error("Cannot create a new connection for {} {}", pool, e);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org