[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5287: Mpfs opensbi redefinition fixes

[GitBox <gi...@apache.org>]

pkarashchenko commented on a change in pull request #5287:
URL: https://github.com/apache/incubator-nuttx/pull/5287#discussion_r788769675



##########
File path: arch/risc-v/src/mpfs/mpfs_opensbi.c
##########
@@ -118,6 +117,16 @@ static int  mpfs_irqchip_init(bool cold_boot);
 static int  mpfs_ipi_init(bool cold_boot);
 static int  mpfs_timer_init(bool cold_boot);
 
+/****************************************************************************
+ * Extern Function Declarations
+ ****************************************************************************/
+
+/* riscv_internal.h cannot be included due to a number of redefinition
+ * conflicts.  Thus, define the riscv_lowputc() with the extern definition.
+ */
+
+extern void riscv_lowputc(char ch);

Review comment:
       Maybe better to switch to `up_putc` and include `nuttx/arch.h`? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org