You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/21 13:53:46 UTC
[GitHub] [trafficcontrol] zrhoffman opened a new pull request #4649: CDN-in-a-Box SMTP server + user registration API test
zrhoffman opened a new pull request #4649:
URL: https://github.com/apache/trafficcontrol/pull/4649
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
This PR
- - [x] is not related to any Issue<!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
- adds a SMTP server to CDN-in-a-Box and
- adds an API test for user registration
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- CDN in a Box
- Documentation
- Traffic Control Client (Go)
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
* Run the API tests, confirm the new test passes (it makes use of the SMTP server)
* Revert 666550760d (#4647), rebuild the Traffic Ops CiaB image, run the API tests, and verify that the new test fails
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
- [x] This PR includes tests
- [x] This PR includes documentation
- [x] This PR includes an update to CHANGELOG.md
- [x] This PR includes any and all required license headers
- [x] This PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on issue #4649: CDN-in-a-Box SMTP server + user registration API test
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #4649:
URL: https://github.com/apache/trafficcontrol/pull/4649#issuecomment-617345279
I think this is good, but I don't think we want to make a full-featured CIAB a requirement for running the TO API tests. Can we optionally disable certain tests that require external services like an SMTP server?
If we can do that, then we should also consider adding TO API tests for endpoints that use Riak, which should also be optional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4649: CDN-in-a-Box SMTP server + user registration API test
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #4649:
URL: https://github.com/apache/trafficcontrol/pull/4649#discussion_r412545165
##########
File path: traffic_ops/testing/api/v2/user_test.go
##########
@@ -37,6 +39,9 @@ func TestUsers(t *testing.T) {
GetTestUsers(t)
GetTestUserCurrent(t)
UserTenancyTest(t)
+ if includeSystemTests {
+ UserRegistrationTest(t)
Review comment:
since this force-deletes users, we should include a comment that this test needs to run last in the sequence, otherwise tests that come after it may fail, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on issue #4649: CDN-in-a-Box SMTP server + user registration API test
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on issue #4649:
URL: https://github.com/apache/trafficcontrol/pull/4649#issuecomment-617414423
Okay, added the `includeSystemTests` option in 95763940d2. It can be set from CLI or in the config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4649: CDN-in-a-Box SMTP server + user registration API test
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #4649:
URL: https://github.com/apache/trafficcontrol/pull/4649#discussion_r412585462
##########
File path: traffic_ops/testing/api/v2/user_test.go
##########
@@ -37,6 +39,9 @@ func TestUsers(t *testing.T) {
GetTestUsers(t)
GetTestUserCurrent(t)
UserTenancyTest(t)
+ if includeSystemTests {
+ UserRegistrationTest(t)
Review comment:
Yes. Included a comment about this in 53b2e5816.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org